Allow users to input data with a TreeSummarizedExperiment object #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This responds to issue statdivlab#64, wherein we decided to allow users to input `TreeSummarizedExperiment` objects, in response to continued errors from the `phyloseq` package. This currently implements the core functionality, without consideration to using `radEmu` after aggregating `TreeSummarizedExperiment` objects.
|
great job with the test file here to test your new functionality!! I like to also test that my desired errors come up when they should, so I might add one more quick test that when you forget the assay argument you get your desired error. |
|
Thank you for this suggestion, @svteichman! I will be sure to add this error check and figure out why I am getting a warning message. |
|
@svteichman I implemented that error check and this code now passes checks. Whenever you have a moment to review, this should be good to merge! |
|
This looks great to me - I'll merge this, and you can close the related issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This responds to issue #64, wherein we decided to allow users to input
TreeSummarizedExperimentobjects, in response to continued errors from thephyloseqpackage. This currently implements the core functionality, without consideration to usingradEmuafter aggregatingTreeSummarizedExperimentobjects.