fix sdist build #729
Open
fix sdist build #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the sdist build currently doesn't include the `csrc` directory, making the PyPi sdist impossible to build. fixes state-spaces#720
|
Comparing the PyPi wheel and the sdist built from this patch: wget https://files.pythonhosted.org/packages/1d/c7/6e21ecece28e6d625f42e708c7523cd78ec82d1622f98562f82bf02748b7/mamba_ssm-2.2.4.tar.gz
tar -tf mamba_ssm-2.2.4.tar.gz > pypi_wheel.txt
rm -rf mamba_ssm.egg-info && MAMBA_SKIP_CUDA_BUILD=TRUE python -m build --sdist # optionally add --installer=uv
tar -tf dist/mamba_ssm-2.2.4.tar.gz > fixed_sdist.txt
diff -p pypi_wheel.txt fixed_sdist.txt*** pypi_wheel.txt 2025-05-19 17:33:47.407399056 +0200
--- fixed_sdist.txt 2025-05-19 17:34:36.050753906 +0200
***************
*** 1,8 ****
--- 1,28 ----
mamba_ssm-2.2.4/
mamba_ssm-2.2.4/AUTHORS
mamba_ssm-2.2.4/LICENSE
+ mamba_ssm-2.2.4/MANIFEST.in
mamba_ssm-2.2.4/PKG-INFO
mamba_ssm-2.2.4/README.md
+ mamba_ssm-2.2.4/csrc/
+ mamba_ssm-2.2.4/csrc/selective_scan/
+ mamba_ssm-2.2.4/csrc/selective_scan/reverse_scan.cuh
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan.cpp
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan.h
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_bwd_bf16_complex.cu
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_bwd_bf16_real.cu
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_bwd_fp16_complex.cu
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_bwd_fp16_real.cu
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_bwd_fp32_complex.cu
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_bwd_fp32_real.cu
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_bwd_kernel.cuh
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_common.h
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_fwd_bf16.cu
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_fwd_fp16.cu
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_fwd_fp32.cu
+ mamba_ssm-2.2.4/csrc/selective_scan/selective_scan_fwd_kernel.cuh
+ mamba_ssm-2.2.4/csrc/selective_scan/static_switch.h
+ mamba_ssm-2.2.4/csrc/selective_scan/uninitialized_copy.cuh
mamba_ssm-2.2.4/mamba_ssm/
mamba_ssm-2.2.4/mamba_ssm/__init__.py
mamba_ssm-2.2.4/mamba_ssm/distributed/
*************** mamba_ssm-2.2.4/mamba_ssm.egg-info/top_l
*** 51,53 ****
--- 71,75 ----
mamba_ssm-2.2.4/pyproject.toml
mamba_ssm-2.2.4/setup.cfg
mamba_ssm-2.2.4/setup.py
+ mamba_ssm-2.2.4/tests/
+ mamba_ssm-2.2.4/tests/test_generation.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the sdist build currently doesn't include the
csrcdirectory, making the PyPi sdist impossible to build.fixes #720