Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up dependencies #9

Merged
merged 2 commits into from
May 7, 2024
Merged

Clean up dependencies #9

merged 2 commits into from
May 7, 2024

Conversation

arneso-ssb
Copy link
Member

@arneso-ssb arneso-ssb commented May 7, 2024 •
edited
Loading

  • Add missing dependencies and remove unused ones. Tested that installing the library on a clean project works.
  • Fixed mypy errors

@arneso-ssb arneso-ssb force-pushed the deptry branch 3 times, most recently from 11313ea to 6b4b838 Compare May 7, 2024 07:31
bryeng
bryeng previously approved these changes May 7, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arneso-ssb arneso-ssb requested a review from bryeng May 7, 2024 15:39
@bryeng bryeng merged commit ede94d2 into main May 7, 2024
14 checks passed
@arneso-ssb arneso-ssb deleted the deptry branch May 8, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryeng bryeng bryeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arneso-ssb @bryeng