feat: connection config.toml in connection details #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenstad
requested review from
erikgb and
mariatsji
and removed request for
erikgb
erikgb
reviewed
Jan 14, 2025
erikgb
reviewed
Jan 14, 2025
Merged
Ait #101 |
tenstad
force-pushed
the
connection-config
branch
from
6fe65e0 to
2fe486c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only exposing the
secretKeyin a connection detail, and theaccessKeyin status, makes it very difficult to create a secret usable by the aws-s3 and aws-iam provider (configs).Could extend with s3 url in the future, see https://s3.amazonaws.com/artifacts.h2o.ai/releases/ai/h2o/dai/rel-1.8.6-31/docs/userguide/config_toml.html#sample-config-toml-file