Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: set Cloudian Group and User ids from Crossplane external-name #102

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

erikgb
Copy link
Member

@erikgb erikgb commented Jan 14, 2025

Cloudian GroupId seems like an "external name" to me, and using the Crossplane external-name ensures that we don't get any confusion in the mapping between Crossplane and Cloudian.

@erikgb erikgb requested review from tenstad and mariatsji January 14, 2025 16:11
Copy link
Member

@tenstad tenstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to implement selector in

GroupID string `json:"groupId"`
then?

@tenstad
Copy link
Member

tenstad commented Jan 14, 2025

And externalname in

UserID string `json:"userId"`
as well?

@erikgb erikgb changed the title chore!: set Cloudian GroupId from Crossplane external-name chore!: set Cloudian Group and User ids from Crossplane external-name Jan 14, 2025
@erikgb
Copy link
Member Author

erikgb commented Jan 14, 2025

And externalname in

UserID string `json:"userId"`

as well?

Done!

@erikgb erikgb merged commit 5c60527 into statnett:main Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants