Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove mentions of defaulting #59

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix: remove mentions of defaulting #59

merged 2 commits into from
Dec 17, 2024

Conversation

tenstad
Copy link
Member

@tenstad tenstad commented Dec 17, 2024

Clarifies empty instead of default.
Also no need create an empty group to use it's zero values - can specify zero values directly in Deref.

@tenstad tenstad requested review from mariatsji and erikgb and removed request for mariatsji December 17, 2024 10:30
@tenstad tenstad changed the title fix: remove group defaulting functionality fix: remove mentions of defaulting Dec 17, 2024
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariatsji mariatsji merged commit ae2e679 into main Dec 17, 2024
5 checks passed
@mariatsji mariatsji deleted the rm-default branch December 17, 2024 12:43
@statnett-bot statnett-bot bot mentioned this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants