Support connecting using TCP #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this repository is old, hopefully, this PR will help someone. As I used to have a fork that used TCP, but never actually published. I can think of different ways of building the client to avoid having several functions and have just one with options, but to keep it backwards compatible, and bring radical changes to the code.
My use-case for TCP is that I have some servers that use statsd/server and for some reason the load balancer behind our telegraf server couldn't handle UDP connections. If this PR gets approved, I can submit a PR to address statsd/system#4 too.
I couldn't find any contribution guide, for this repository, so I did my best. There weren't any tests for the initialization of the client, so I didn't add them, but happy to do it if required.