Fix some warnings. (#310)

* Fix some warnings messages. * More warning fixes. * Address review comments. Fix MacOS issues. * More warning fixes. * More Windows specific fixes. * Fix macos and windows warnings. * Fix warnings in timer.nim Refactor to remove `result`. Improve performance and behavior of timer to string procedure. Add tests.
status-im · Nov 2, 2022 · 6525f4c · 6525f4c
1 parent 2414646
commit 6525f4c
Show file tree

Hide file tree

Showing 11 changed files with 182 additions and 133 deletions.
diff --git a/chronos/asyncloop.nim b/chronos/asyncloop.nim
@@ -237,11 +237,11 @@ func getAsyncTimestamp*(a: Duration): auto {.inline.} =
   var res = nansec div milsec
   let mid = nansec mod milsec
   when defined(windows):
-    res = min(cast[int64](high(int32) - 1), res)
+    res = min(int64(high(int32) - 1), res)
     result = cast[DWORD](res)
     result += DWORD(min(1'i32, cast[int32](mid)))
   else:
-    res = min(cast[int64](high(int32) - 1), res)
+    res = min(int64(high(int32) - 1), res)
     result = cast[int32](res)
     result += min(1, cast[int32](mid))
 

diff --git a/chronos/handles.nim b/chronos/handles.nim
@@ -13,11 +13,10 @@ else:
   {.push raises: [].}
 
 import std/[net, nativesockets]
-import stew/base10
 import ./asyncloop
 
 when defined(windows) or defined(nimdoc):
-  import os, winlean
+  import os, winlean, stew/base10
   const
     asyncInvalidSocket* = AsyncFD(-1)
     TCP_NODELAY* = 1

diff --git a/chronos/ioselects/ioselectors_epoll.nim b/chronos/ioselects/ioselectors_epoll.nim
@@ -433,7 +433,7 @@ proc selectInto*[T](s: Selector[T], timeout: int,
             if posix.read(cint(fdi), addr data,
                           sizeof(SignalFdInfo)) != sizeof(SignalFdInfo):
               raiseIOSelectorsError(osLastError())
-            if cast[int](data.ssi_pid) == pkey.param:
+            if data.ssi_pid == uint32(pkey.param):
               rkey.events.incl(Event.Process)
             else:
               inc(i)

diff --git a/chronos/streams/tlsstream.nim b/chronos/streams/tlsstream.nim
@@ -468,7 +468,7 @@ proc newTLSClientAsyncStream*(rsource: AsyncStreamReader,
 
   if TLSFlags.NoVerifyHost in flags:
     sslClientInitFull(res.ccontext, addr res.x509, nil, 0)
-    initNoAnchor(res.xwc, addr res.x509.vtable)
+    x509NoanchorInit(res.xwc, addr res.x509.vtable)
     sslEngineSetX509(res.ccontext.eng, addr res.xwc.vtable)
   else:
     sslClientInitFull(res.ccontext, addr res.x509,