Skip to content

Commit

Permalink
Use the make question option to avoid rebuild on macOS
Browse files Browse the repository at this point in the history
There was already the earlier strange ` before the
"unity.a' is up to date message on macOS.

Turns out it might still not work on macOS because of certain
verbosity levels.

So use the question option instead of dry-run + grep as the
latter is more brittle, and the former is intended for this
purpose.
  • Loading branch information
kdeme committed Jul 26, 2024
1 parent 608d10a commit 23d0cf0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/build_static_deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export ROCKSDB_DISABLE_BZIP=1
export PORTABLE=1
export DEBUG_LEVEL=0

if ${MAKE} -C "${ROCKSDB_LIB_DIR}" --dry-run unity.a | grep -q "unity.a' is up to date."; then
if ${MAKE} -C "${ROCKSDB_LIB_DIR}" -q unity.a; then
echo "RocksDb static libraries already built. Skipping build."
exit 0
else
Expand Down

0 comments on commit 23d0cf0

Please sign in to comment.