Add majority of option type getter and setters.

status-im · Jul 3, 2024 · 45f5753 · 45f5753
1 parent aaaa2be
commit 45f5753
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 14 deletions.
diff --git a/rocksdb/options/backupopts.nim b/rocksdb/options/backupopts.nim
@@ -32,16 +32,24 @@ proc cPtr*(backupOpts: BackupEngineOptionsRef): BackupEngineOptionsPtr =
   doAssert not backupOpts.isClosed()
   backupOpts.cPtr
 
-# template opt(nname, ntyp, ctyp: untyped) =
-#   proc `nname=`*(backupOpts: BackupEngineOptionsRef, value: ntyp) =
-#     doAssert not backupOpts.isClosed()
-#     `rocksdb_options_set nname`(backupOpts.cPtr, value.ctyp)
+template opt(nname, ntyp, ctyp: untyped) =
+  proc `nname=`*(backupOpts: BackupEngineOptionsRef, value: ntyp) =
+    doAssert not backupOpts.isClosed()
+    `rocksdb_backup_engine_options_set nname`(backupOpts.cPtr, value.ctyp)
 
-#   proc `nname`*(backupOpts: BackupEngineOptionsRef): ntyp =
-#     doAssert not backupOpts.isClosed()
-#     ntyp `rocksdb_options_get nname`(backupOpts.cPtr)
+  proc `nname`*(backupOpts: BackupEngineOptionsRef): ntyp =
+    doAssert not backupOpts.isClosed()
+    ntyp `rocksdb_backup_engine_options_get nname`(backupOpts.cPtr)
 
-# opt shareTableFiles, bool, uint8
+opt shareTableFiles, bool, uint8
+opt sync, bool, uint8
+opt destroyOldData, bool, uint8
+opt backupLogFiles, bool, uint8
+opt backupRateLimit, int, uint64
+opt restoreRateLimit, int, uint64
+opt shareFilesWithChecksumNaming, bool, cint
+opt maxBackgroundOperations, int, cint
+opt callbackTriggerIntervalSize, int, uint64
 
 proc defaultBackupEngineOptions*(
     backupDir: string, autoClose = false

diff --git a/rocksdb/transactions/txdbopts.nim b/rocksdb/transactions/txdbopts.nim
@@ -30,13 +30,23 @@ proc cPtr*(txDbOpts: TransactionDbOptionsRef): TransactionDbOptionsPtr =
   doAssert not txDbOpts.isClosed()
   txDbOpts.cPtr
 
-# TODO: Add setters and getters for backup options properties.
+template setOpt(nname, ntyp, ctyp: untyped) =
+  proc `nname=`*(txDbOpts: TransactionDbOptionsRef, value: ntyp) =
+    doAssert not txDbOpts.isClosed()
+    `rocksdb_transactiondb_options_set nname`(txDbOpts.cPtr, value.ctyp)
+
+setOpt maxNumLocks, int, int64
+setOpt numStripes, int, csize_t
+setOpt transactionLockTimeout, int, int64
+setOpt defaultLockTimeout, int, int64
 
 proc defaultTransactionDbOptions*(
     autoClose = false
 ): TransactionDbOptionsRef {.inline.} =
-  createTransactionDbOptions(autoClose)
+  let txDbOpts = createTransactionDbOptions(autoClose)
+
   # TODO: set prefered defaults
+  txDbOpts
 
 proc close*(txDbOpts: TransactionDbOptionsRef) =
   if not txDbOpts.isClosed():

diff --git a/rocksdb/transactions/txopts.nim b/rocksdb/transactions/txopts.nim
@@ -30,7 +30,17 @@ proc cPtr*(txOpts: TransactionOptionsRef): TransactionOptionsPtr =
   doAssert not txOpts.isClosed()
   txOpts.cPtr
 
-# TODO: Add setters and getters for backup options properties.
+template setOpt(nname, ntyp, ctyp: untyped) =
+  proc `nname=`*(txOpts: TransactionOptionsRef, value: ntyp) =
+    doAssert not txOpts.isClosed()
+    `rocksdb_transaction_options_set nname`(txOpts.cPtr, value.ctyp)
+
+setOpt setSnapshot, bool, uint8
+setOpt deadlockDetect, bool, uint8
+setOpt lockTimeout, int, int64
+setOpt deadlockDetectDepth, int, int64
+setOpt maxWriteBatchSize, int, csize_t
+setOpt skipPrepare, bool, uint8
 
 proc defaultTransactionOptions*(autoClose = false): TransactionOptionsRef {.inline.} =
   createTransactionOptions(autoClose)

diff --git a/tests/options/test_backupopts.nim b/tests/options/test_backupopts.nim
@@ -20,14 +20,14 @@ suite "BackupEngineOptionsRef Tests":
     backupOpts.close()
 
   test "Test defaultBackupEngineOptions":
-    let backupOpts = defaultBackupEngineOptions()
+    let backupOpts = defaultBackupEngineOptions(".")
 
     check not backupOpts.cPtr.isNil()
 
     backupOpts.close()
 
   test "Test close":
-    let backupOpts = defaultBackupEngineOptions()
+    let backupOpts = defaultBackupEngineOptions(".")
 
     check not backupOpts.isClosed()
     backupOpts.close()

diff --git a/tests/test_rocksdb.nim b/tests/test_rocksdb.nim
@@ -416,7 +416,6 @@ suite "RocksDbRef Tests":
 
     cfOpts.compression = lz4Compression
     check cfOpts.compression == lz4Compression
-    let cfDescriptor = initColFamilyDescriptor(CF_DEFAULT, cfOpts)
     let db1 = openRocksDb(dbPath, columnFamilies = @[cfDescriptor]).get()
     check db1.put(key, val).isOk()
     db1.close()