If vendor RocksDb files have changed the trigger a clean rebuild. #49
Conversation
| else | ||
| ${REPO_DIR}/scripts/clean_build_artifacts.sh | ||
| echo "Building RocksDb static libraries." | ||
| fi |
There was a problem hiding this comment.
@arnetheduck This should fix the problem you encountered. If we have already built RocksDb then it won't be rebuilt unless you switch the code then it will check if a rebuild is needed, and will clean the build artifacts just before completing the full rebuild.
By the way I couldn't find a good way to clean up the build artifacts as you suggested without triggering RocksDb to rebuild and we don't want to rebuild RocksDb every time, that would be too slow. This is because the make file targets are all linked together and if any files are changed or deleted then it will trigger a rebuild up the path of what was changed.
There was a problem hiding this comment.
alright! nice bonus with the echo, without it looks like the build has frozen..
No description provided.