More flexibility to contract DSL, Async contract caller #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing bugging me about contract dsl was the necessity to call
call/send/exec
over each invocation (e.g.let myValue = await myContract.getMyValue().call()
). So I tried to fix that and here's what I came up with. Contract dsl is still async-and-web3-agnostic, but requires sender to definecreateMutableContractInvocation
,createImutableContractInvocation
andcreateContractDeployment
functions, whose results are blindly passed to the caller. This allows to define async contract sender, while still keeping the old api around. See difftest_contracts.nim
for demonstration of how new api looks like. Withsend/exec/call
functions gone, the new way to adjust invocation options (likevalue
,gas
,gasPrice
, etc) is theadjust
macro, that creates a copy of async sender, adjusting its fields. E.g.Any feedback is welcome.