Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect chainId from TransactionArgs when signing #152

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

yglukhov
Copy link
Contributor

@yglukhov yglukhov commented Jun 7, 2024

This fixes the problem of assertion failure in proc send*(web3: Web3, c: TransactionArgs, chainId: ChainId), and eliminates the need for this function along with func encodeTransaction*(s: TransactionArgs, pk: PrivateKey, chainId: ChainId): seq[byte] as they are redundant because chainId option already exists in TransactionArgs but was not respected during the signature. Thus these functions are marked deprecated now.

The aforementioned assertion failure happens when user provides the chainId without the privateKey, which IMO should not affect each other in the high level.

@jangko jangko merged commit 954c23c into status-im:master Jun 10, 2024
12 checks passed
@yglukhov yglukhov deleted the chain-id branch June 10, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants