Respect chainId from TransactionArgs when signing #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem of assertion failure in
proc send*(web3: Web3, c: TransactionArgs, chainId: ChainId)
, and eliminates the need for this function along withfunc encodeTransaction*(s: TransactionArgs, pk: PrivateKey, chainId: ChainId): seq[byte]
as they are redundant becausechainId
option already exists inTransactionArgs
but was not respected during the signature. Thus these functions are marked deprecated now.The aforementioned assertion failure happens when user provides the
chainId
without theprivateKey
, which IMO should not affect each other in the high level.