import: read from era files #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR extends the `nimbus import` command to also allow reading from era files - this command allows creating or topping up an existing database with data coming from era files instead of network sync. * add `--era1-dir` and `--max-blocks` options to command line * make `persistBlocks` report basic stats like transactions and gas * improve error reporting in several API * allow importing multiple RLP files in one go * clean up logging options to match nimbus-eth2 * make sure database is closed properly on shutdown
|
currently, when running the command twice, it fails sometimes depending on the chunk size, ie |
jangko
reviewed
May 31, 2024
nimbus/nimbus.nim
Outdated
|
|
||
| case conf.cmd | ||
| of NimbusCmd.`import`: | ||
| importBlocks(conf, com) | ||
| else: | ||
| if conf.trustedSetupFile.isSome: |
There was a problem hiding this comment.
loadKzgTrustedSetup should be called before importing blocks or subsequent call to kzg functions in block validation will return error if Cancun hardfork is active.
There was a problem hiding this comment.
ah - it was explicitly disabled for import, for some reason. I'll move it back then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
nimbus importcommand to also allow reading from era files - this command allows creating or topping up an existing database with data coming from era files instead of network sync.--era1-dirand--max-blocksoptions to command linepersistBlocksreport basic stats like transactions and gas