Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable vid reuse compaction #2276

Merged
merged 3 commits into from
Jun 1, 2024
Merged

disable vid reuse compaction #2276

merged 3 commits into from
Jun 1, 2024

Conversation

arnetheduck
Copy link
Member

The current implementation cannot be used practically since it causes several full reallocations of the whole free list per deletion - it needs to be reimplemented, or the chain cannot practically progress beyond ~2.5M blocks where a lot of removals happen.

The current implementation cannot be used practically since it causes
several full reallocations of the whole free list per deletion - it
needs to be reimplemented, or the chain cannot practically progress
beyond ~2.5M blocks where a lot of removals happen.
@arnetheduck
Copy link
Member Author

image

CPU Time
1 of 36: 32.7%  (3.671s of 11.214s)

libc.so.6 ! __memmove_evex_unaligned_erms - memmove-vec-unaligned-erms.S
nimbus ! incrSeqV3 + 0xae - sysstr.nim:290
nimbus ! vidDispose__dbZaristoZaristo95vid_98 + 0x172 - aristo_vid.nim:74
nimbus ! deleteImpl__dbZaristoZaristo95delete_525 + 0x15e - aristo_delete.nim:343
nimbus ! delete__dbZaristoZaristo95delete_832 + 0x12d - aristo_delete.nim:458
nimbus ! delete__dbZaristoZaristo95delete_1014 + 0x1fb - aristo_delete.nim:478
nimbus ! accDelete__dbZcore95dbZbackendZaristo95dbZhandlers95aristo_863 + 0x201 - handlers_aristo.nim:367
nimbus ! delete__dbZledgerZdistinct95ledgers_1156 + 0x41 - distinct_ledgers.nim:158
nimbus ! persist__dbZledgerZaccounts95ledger_9302 + 0x51b - accounts_ledger.nim:627
nimbus ! processTransactionImpl__coreZexecutorZprocess95transaction_89 + 0x381 - process_transaction.nim:125
nimbus ! processTransaction__coreZexecutorZprocess95transaction_199 + 0x6f - process_transaction.nim:182
nimbus ! processTransactions__coreZexecutorZprocess95block_15 + 0x1e0 - process_block.nim:44
nimbus ! procBlkPreamble__coreZexecutorZprocess95block_83 + 0x4d7 - process_block.nim:82
nimbus ! processBlock__coreZexecutorZprocess95block_1826 + 0xe4 - process_block.nim:170
nimbus ! persistBlocksImpl__coreZchainZpersist95blocks_174 + 0x1103 - persist_blocks.nim:133
libc.so.6 ! [Unknown stack frame(s)]
nimbus ! persistBlocks__coreZchainZpersist95blocks_997 + 0x555 - persist_blocks.nim:243

@arnetheduck
Copy link
Member Author

arnetheduck commented Jun 1, 2024

The long list happens due to the spam that prompted EIP-161

@arnetheduck arnetheduck merged commit ef864ba into master Jun 1, 2024
27 checks passed
@arnetheduck arnetheduck deleted the no-compaction branch June 1, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants