Enable consensus_sim #2441
Merged
Enable consensus_sim #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Jul 3, 2024
tersec
reviewed
Jul 4, 2024
| proc main() = | ||
| const basePath = "tests" / "fixtures" / "eth_tests" / "BlockchainTests" | ||
| const basePath = "tests/fixtures/eth_tests/BlockchainTests" |
There was a problem hiding this comment.
Does this preserve functionality on Windows? / uses DirSep, which might also be \ on Windows.
While for non-\\?\ based paths in Windows, or those for many purposes for the Win32 APIs, they'll handle either / or \, it means that if one has to switch to the style of paths which allow more than MAX_PATH == 260 length, e.g, because of a source directory with a long name, then using / in a hardcoded way would cause this to fail.
There was a problem hiding this comment.
So far the blockchain tests folder only contains shallow recursion and the file names also short. And it still works on windows
jangko
added a commit
that referenced
this pull request
Aug 15, 2024
* Enable consensus_sim * Remove isFile check
tersec
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Wiring ForkedChainRef to other components - Disable majority of hive simulators - Only enable pyspec_sim for the moment - The pyspec_sim is using a smaller RPC service wired to ForkedChainRef - The RPC service will gradually grow * Addressing PR review * Fix test_beacon/setup_env * Enable consensus_sim (#2441) * Enable consensus_sim * Remove isFile check * Enable Engine API jwt auth tests and exchange cap tests * Enable engine api in build_sim.sh * Wire ForkedChainRef to Engine API newPayload * Wire Engine API getBodies to ForkedChainRef * Wire Engine API api_forkchoice to ForkedChainRef * Wire more RPC methods to ForkedChainRef * Implement eth_syncing * Implement eth_call and eth_getlogs * TxPool: simplify smartHead * Fix smartHead usage * Fix txpool headDiff * Remove hasBlockHeader and use headerExists * Addressing review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR meant to be merged to #2423