Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable CI on nimbus nim-libp2p-auto-bump-unstable branch #3916

Draft
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Draft

enable CI on nimbus nim-libp2p-auto-bump-unstable branch #3916

wants to merge 1 commit into from

Conversation

Menduist
Copy link
Contributor

This PR just exists to allow CI to run, should not be merged / closed

@github-actions
Copy link

github-actions bot commented Jul 27, 2022 •
edited
Loading

Unit Test Results

         9 files  ±0    1 262 suites  ±0   24m 15s ⏱️ - 10m 37s
  4 556 tests ±0    4 209 ✔️ ±0  347 💤 ±0  0 ❌ ±0 
19 158 runs  ±0  18 760 ✔️ ±0  398 💤 ±0  0 ❌ ±0 

Results for commit 7f57c91. ± Comparison against base commit 8c4ddd6.

♻️ This comment has been updated with latest results.

@Menduist Menduist force-pushed the nim-libp2p-auto-bump-unstable branch 11 times, most recently from fc60031 to c4569c5 Compare August 3, 2022 11:34
@Menduist Menduist force-pushed the nim-libp2p-auto-bump-unstable branch 2 times, most recently from a2ee776 to 228031c Compare August 3, 2022 17:05
@Menduist Menduist force-pushed the nim-libp2p-auto-bump-unstable branch from 228031c to 938ae55 Compare August 23, 2022 17:36
@Menduist Menduist force-pushed the nim-libp2p-auto-bump-unstable branch 6 times, most recently from c6cb5e7 to ad389ff Compare September 6, 2022 13:57
@Menduist Menduist force-pushed the nim-libp2p-auto-bump-unstable branch 2 times, most recently from a208966 to fc8d280 Compare September 12, 2022 15:49
@Menduist Menduist mentioned this pull request Sep 14, 2022
Merged
@Menduist Menduist force-pushed the nim-libp2p-auto-bump-unstable branch 2 times, most recently from a8730ea to e6b128f Compare September 14, 2022 12:07
@Menduist Menduist changed the title nim-libp2p unstable auto bump nimbus nim-libp2p unstable auto bump Sep 14, 2022
@status-im-auto status-im-auto force-pushed the nim-libp2p-auto-bump-unstable branch 3 times, most recently from c1b4296 to 20cdbd9 Compare March 18, 2024 10:38
@status-im-auto status-im-auto force-pushed the nim-libp2p-auto-bump-unstable branch 8 times, most recently from c016a67 to ed3f89f Compare March 27, 2024 10:54
@status-im-auto status-im-auto force-pushed the nim-libp2p-auto-bump-unstable branch 2 times, most recently from 9a43785 to 53b8b56 Compare March 28, 2024 10:34
@status-im-auto status-im-auto force-pushed the nim-libp2p-auto-bump-unstable branch 2 times, most recently from 326973b to 1cfafa9 Compare April 9, 2024 18:15
@diegomrsantos
Copy link
Contributor

does anyone know why this is necessary? @tersec @arnetheduck ?

@tersec
Copy link
Contributor

tersec commented May 10, 2024

does anyone know why this is necessary? @tersec @arnetheduck ?

This PR just exists to allow CI to run

@diegomrsantos
Copy link
Contributor

I'm not familiar with this requirement, could you please elaborate?

@diegomrsantos
Copy link
Contributor

I think I get it now, this is to make it possible to run CI on the nim-libp2p-auto-bump-unstable branch.

@diegomrsantos diegomrsantos changed the title nimbus nim-libp2p unstable auto bump enable CI on nimbus nim-libp2p-auto-bump-unstable branch May 10, 2024
@tersec
Copy link
Contributor

tersec commented May 10, 2024

I think I get it now, this is to make it possible to run CI on the nim-libp2p-auto-bump-unstable branch.

Indeed

@diegomrsantos
Copy link
Contributor

I believe we can achieve the same by adding the branch here

nimbus-eth2/.github/workflows/ci.yml

Line 12 in 73738c7

branches:
and checking the workflow run here https://github.com/status-im/nimbus-eth2/actions

@arnetheduck
Copy link
Member

broadly the bumping happens to perform fleet testing for libp2p changes before upgrading, including running them on the fleet: https://metrics.status.im/d/pgeNfj2Wz23/nimbus-fleet-testnets?orgId=1&from=now-3h&to=now&var-instance=geth-10.ih-eu-mda1.nimbus.holesky&var-container=beacon-node-holesky-libp2p&refresh=15m

@diegomrsantos
Copy link
Contributor

The bumping happens on a GitHub workflow and is independent of this PR. My question was related to the existence of this PR that can't be merged - something unusual, at least to me. It seems it is to make it possible to have the CI jobs run for the branch in question, but there are other ways of accomplishing that.

@arnetheduck
Copy link
Member

can't be merged

there's a build that builds the branch - if the branch with this name is removed, the build fails and cannot be deployed to the fleet

@diegomrsantos
Copy link
Contributor

diegomrsantos commented May 10, 2024 •
edited
Loading

It's possible to make a workflow run every time there's a push to a branch, as I pointed out. I was thinking about removing this PR, not the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Menduist @diegomrsantos @tersec @arnetheduck @etan-status