Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra REST forked BeaconBlockBody reading support #6551

Closed
wants to merge 1 commit into from
Closed

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Sep 16, 2024

Won't be merged in September's release cycle, because it affects Deneb REST block reading and can't be readily isolated into future-forks-only codepaths aside from not very usefully disabling it by default.

It's not yet complete, either, because of the requests in ExecutionPayload, but those might be changing soon, so won't address them yet.

@tersec
Copy link
Contributor Author

tersec commented Sep 16, 2024

version-2-0 CI failure is unrelated: nim-lang/Nim#24104

@tersec tersec marked this pull request as draft September 16, 2024 07:05
Copy link

Unit Test Results

         9 files  ±0    1 346 suites  ±0   49m 48s ⏱️ + 1m 42s
  5 142 tests ±0    4 794 ✔️ ±0  348 💤 ±0  0 ±0 
21 198 runs  ±0  20 794 ✔️ ±0  404 💤 ±0  0 ±0 

Results for commit 0d9832d. ± Comparison against base commit 72b5c2b.

@tersec
Copy link
Contributor Author

tersec commented Sep 16, 2024

#6552 is better

@tersec tersec closed this Sep 16, 2024
@tersec tersec deleted the R9O branch September 18, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant