changes for unified[wip] #6758
Draft
changes for unified[wip] #6758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1869,7 +1869,7 @@ proc onSlotStart(node: BeaconNode, wallTime: BeaconTime, | |||
|
|
|||
| proc onSecond(node: BeaconNode, time: Moment) = | |||
| # Nim GC metrics (for the main thread) | |||
| updateThreadMetrics() | |||
| # updateThreadMetrics() | |||
There was a problem hiding this comment.
Metrics collection not generated, and this code is commented. possible solutions may required a significant rewrite (using some strategy simliar to an aggregator pattern)
| @@ -2364,7 +2364,7 @@ proc doRunBeaconNode(config: var BeaconNodeConf, rng: ref HmacDrbgContext) {.rai | |||
|
|
|||
| # Nim GC metrics (for the main thread) will be collected in onSecond(), but | |||
| # we disable piggy-backing on other metrics here. | |||
| setSystemMetricsAutomaticUpdate(false) | |||
| # setSystemMetricsAutomaticUpdate(false) | |||
| @@ -2548,7 +2548,7 @@ proc handleStartUpCmd(config: var BeaconNodeConf) {.raises: [CatchableError].} = | |||
|
|
|||
| {.pop.} # TODO moduletests exceptions | |||
|
|
|||
| programMain: | |||
| when isMainModule: | |||
There was a problem hiding this comment.
This might be an outdated strategy.however it's present in other "main" modules as well.
What is the impact of using the "when is" approach vs this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some initial changes for unified project.