Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt columns into the BN, except column syncing #6945

Open
wants to merge 63 commits into
base: unstable
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
eebbdc5
init: columns to the block/eth2 processor
agnxsh Jan 19, 2025
3ff4c33
add columns to message router
agnxsh Jan 20, 2025
222cff0
add columns to initializers of Eth2 and BlockProcessor
agnxsh Jan 20, 2025
21d771a
save progress
agnxsh Jan 20, 2025
d3309d5
save progress 2
agnxsh Jan 20, 2025
d4139e0
add column to block verifier
agnxsh Jan 20, 2025
1197f09
save progress, need to rework untrusted syncing
agnxsh Jan 21, 2025
e73379e
add column support to light forward sync
agnxsh Jan 21, 2025
7c75875
save progress test sync manager
agnxsh Jan 21, 2025
c1a2013
fix createDataColumns
agnxsh Jan 21, 2025
38b0421
fix more
agnxsh Jan 21, 2025
8a1825b
added fulu message handlers for column subnets
agnxsh Jan 21, 2025
3dfb2af
activated data column sidecar processing at Fulu
agnxsh Jan 21, 2025
7d79166
fix compilation issues
agnxsh Jan 22, 2025
9756cce
added to T list
agnxsh Jan 22, 2025
d527648
other fixes
agnxsh Jan 22, 2025
2f5e216
fix test
agnxsh Jan 22, 2025
1fc210a
fix result situation in get data column sidecars
agnxsh Jan 24, 2025
514bb3c
fix message router issue
agnxsh Jan 24, 2025
4819e43
gate blob publishing upto deneb
agnxsh Jan 24, 2025
71fdf66
fix message router blob and column progressions
agnxsh Jan 24, 2025
8128944
drop dataColumnOpt from message router
agnxsh Jan 24, 2025
9b5feb6
reversing rman blockVerifier order
agnxsh Jan 25, 2025
3592d34
fixes
agnxsh Jan 25, 2025
e7bc436
several fixes
agnxsh Jan 25, 2025
4077bb4
added debug logs for devnet testing
agnxsh Jan 25, 2025
749a5a9
add blobsOpt isSome check
agnxsh Jan 25, 2025
ceff705
fix copyright years
agnxsh Jan 25, 2025
d82c3f5
couple of fixes and debug logs
agnxsh Jan 26, 2025
9351c26
fix issue
agnxsh Jan 27, 2025
1fef674
resolved review comments, enabled more debug logs, fixed a couple of …
agnxsh Jan 27, 2025
7b3304b
fix indentation
agnxsh Jan 27, 2025
97a190f
limit processBlobSidecar < Fulu
agnxsh Jan 27, 2025
947a71b
try to gate a few operations to < Fulu
agnxsh Jan 27, 2025
3762c2c
gate more
agnxsh Jan 27, 2025
0afb4a2
halt rman blob loop post fulu fork epoch
agnxsh Jan 28, 2025
9a6f749
removed debugEchoes
agnxsh Jan 28, 2025
bdd3d50
don't ignore data column sidecars, even if you already have block
agnxsh Jan 28, 2025
609ed1d
typo
agnxsh Jan 28, 2025
80c36a7
fix upgrade to fulu function
agnxsh Jan 28, 2025
302407d
modify upgrade to fulu
agnxsh Jan 28, 2025
656ce11
gate blob publishing upto < Fulu
agnxsh Jan 28, 2025
c6ef55a
fix indentation
agnxsh Jan 28, 2025
6cc5ae2
fix fulu state upgrade
agnxsh Jan 28, 2025
5d9badc
updated processDataColumnSidecar ordering
agnxsh Jan 28, 2025
bebe9cb
add upto Capella message handlers and data column sidecars topics in …
agnxsh Jan 28, 2025
4cd6413
fix message handlers
agnxsh Jan 29, 2025
90ad075
fix copyright year
agnxsh Jan 29, 2025
7c7bc22
another fix in upgrade to fulu
agnxsh Jan 29, 2025
c434daf
refine DA checking more
agnxsh Jan 29, 2025
c5461a1
log out time taken to reconstruct
agnxsh Feb 1, 2025
07ce6ef
log out sidecar comms and proof len for testing
agnxsh Feb 1, 2025
a7af551
address review comments
agnxsh Feb 5, 2025
27f2723
fix typo
agnxsh Feb 5, 2025
4cf8a58
use disjoint
agnxsh Feb 5, 2025
0a79a51
remove column support from SyncManager and LFS
agnxsh Feb 22, 2025
c0753d4
Merge branch 'unstable' into column-syncer
agnxsh Feb 22, 2025
b0e0071
Merge branch 'unstable' into column-syncer
agnxsh Mar 4, 2025
26b0ce3
rm useless commented code
agnxsh Mar 4, 2025
72ca013
fix post rebase issue
agnxsh Mar 4, 2025
ff48abd
fix some style issues, and rm debug echoes
agnxsh Mar 4, 2025
0c77fb2
fixed more styling related reviews
agnxsh Mar 4, 2025
66986ed
Merge branch 'unstable' into column-syncer
agnxsh Mar 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion beacon_chain/consensus_object_pools/block_pools_types.nim
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# beacon_chain
# Copyright (c) 2018-2024 Status Research & Development GmbH
# Copyright (c) 2018-2025 Status Research & Development GmbH
# Licensed and distributed under either of
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
Expand Down Expand Up @@ -288,6 +288,7 @@ type
BlockData* = object
blck*: ForkedSignedBeaconBlock
blob*: Opt[BlobSidecars]
dataColumn*: Opt[DataColumnSidecars]

OnBlockAdded*[T: ForkyTrustedSignedBeaconBlock] = proc(
blckRef: BlockRef, blck: T, epochRef: EpochRef,
Expand Down
2 changes: 1 addition & 1 deletion beacon_chain/consensus_object_pools/blockchain_list.nim
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# beacon_chain
# Copyright (c) 2018-2024 Status Research & Development GmbH
# Copyright (c) 2018-2025 Status Research & Development GmbH
# Licensed and distributed under either of
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
Expand Down
13 changes: 6 additions & 7 deletions beacon_chain/consensus_object_pools/data_column_quarantine.nim
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# beacon_chain
# Copyright (c) 2018-2024 Status Research & Development GmbH
# Copyright (c) 2018-2025 Status Research & Development GmbH
# Licensed and distributed under either of
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
Expand Down Expand Up @@ -139,13 +139,12 @@ func hasMissingDataColumns*(quarantine: DataColumnQuarantine,
index: idx)
if dc_identifier notin quarantine.data_columns:
inc col_counter
if quarantine.supernode and col_counter != NUMBER_OF_COLUMNS:
return false
elif quarantine.supernode == false and
col_counter != max(SAMPLES_PER_SLOT, CUSTODY_REQUIREMENT):
return false
else:
if quarantine.supernode and col_counter == NUMBER_OF_COLUMNS:
return true
if quarantine.supernode == false and
col_counter == max(SAMPLES_PER_SLOT, CUSTODY_REQUIREMENT):
return true
false

func hasEnoughDataColumns*(quarantine: DataColumnQuarantine,
blck: fulu.SignedBeaconBlock): bool =
Expand Down
Loading
Loading