-
Notifications
You must be signed in to change notification settings - Fork 281
draft impl for EIP-7805's p2p interface and inclusion list pool. #7290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: focil
Are you sure you want to change the base?
Conversation
Unit Test Results 12 files - 3 2 104 suites - 526 1h 1m 54s ⏱️ - 16m 49s Results for commit 1b7293b. ± Comparison against base commit f996d18. ♻️ This comment has been updated with latest results. |
|
https://github.com/status-im/nimbus-eth2/actions/runs/16248920772/job/45876335181?pr=7290 (the
There are two parts here, repeated several times across different build targets:
These should just not be imported, if they're not used. In current The other part is:
which is from the # https://github.com/ethereum/consensus-specs/blob/dev/specs/_features/eip7805/validator.md#constructing-a-signed-inclusion-list
func compute_inclusion_list_signing_root*(
fork: Fork, genesis_validators_root: Eth2Digest,
message: InclusionList): Eth2Digest =
let domain = get_domain(
fork, DOMAIN_INCLUSION_LIST_COMMITTEE, message.slot.epoch(),
genesis_validators_root)
compute_signing_root(message, domain) where type
# https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.2/specs/_features/eip7805/beacon-chain.md#inclusionlist
InclusionList* = object
slot*: Slot
validator_index*: ValidatorIndex
inclusion_list_committee_root: Eth2Digest
transactions: List[Transaction, MAX_TRANSACTIONS_PER_PAYLOAD]
inclusion_list_committee_root*: Eth2Digest
transactions*: List[Transaction, MAX_TRANSACTIONS_PER_PAYLOAD] it's likely complaining about validator_index*: uint64 with any relevant conversions to/from |
Thanks for the quick and detailed help with debugging! And sorry for my delayed response-- I was waiting to fix all the build errors before pushing the code. |
This PR proposes the following changes: