Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Simplified Send Transaction #16696

Open
3 of 29 tasks
Khushboo-dev-cpp opened this issue Nov 4, 2024 · 3 comments
Open
3 of 29 tasks

EPIC: Simplified Send Transaction #16696

Khushboo-dev-cpp opened this issue Nov 4, 2024 · 3 comments

Comments

@Khushboo-dev-cpp
Copy link
Contributor

Khushboo-dev-cpp commented Nov 4, 2024

Description

As a first step in stabilising and having a bug free send, the team has decided to go ahead with single network send as a version 1.

This epic covers all the changes that need to be done in send as finalised by the team.

Designs: https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25182-169274&t=Ech2sOd4zCGhGFzC-4
User Stories: https://www.notion.so/Making-transactions-Send-Bridge-Simplified-1128f96fb65c80d78d6ed0788776e98f?pvs=4

SubComponents Rework:

Main Tasks:

Miscellaneous TBD:

@micieslak
Copy link
Member

I left some comments in subtasks.

Moreover I noticed one big thing necessary to do along with the planned simplifications. It's consequence of design changes regarding scrolling:

Image

It means that top level layout of SendModal needs to be rethought and organised from scratch with that scrolling behavior in mind. Everything above the list should be put into ListView header probably.

@Khushboo-dev-cpp
Copy link
Contributor Author

I left some comments in subtasks.

Moreover I noticed one big thing necessary to do along with the planned simplifications. It's consequence of design changes regarding scrolling:

Image

It means that top level layout of SendModal needs to be rethought and organised from scratch with that scrolling behavior in mind. Everything above the list should be put into ListView header probably.

@micieslak this behaviour only applies when screen size < 720 px.

But your suggestion for moving everything above the list to listview header makes sense. We could play with sticky property based on screen height.

@anastasiyaig anastasiyaig modified the milestones: 2.32.0 Beta, 2.33.0 Beta Nov 25, 2024
@anastasiyaig
Copy link
Contributor

@alaibe @Khushboo-dev-cpp I moved that to 2.33 milestone as we discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

4 participants