Feat/building simple send #16868
Open
Feat/building simple send #16868
+2,389
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
from
da50bdc to
d350cfb
Compare
Jenkins BuildsClick to see older builds (57)
|
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
3 times, most recently
from
59b4155 to
9f2a213
Compare
Khushboo-dev-cpp
force-pushed
the
feat/UpdateLaunchSendModalMechanism
branch
from
c52e770 to
89daa99
Compare
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
from
9f2a213 to
51fc469
Compare
Base automatically changed from
feat/UpdateLaunchSendModalMechanism
to
master
December 4, 2024 20:34
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
2 times, most recently
from
2a789a7 to
93224cb
Compare
Khushboo-dev-cpp
requested review from
micieslak,
a team,
caybro and
alexjba
as code owners
Khushboo-dev-cpp
requested review from
Cuteivist
and removed request for
a team
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
from
93224cb to
153f94b
Compare
…dialog resizing for simple send fixes #16836
…ed when Simple send is scrolling
…ched outside of storybook
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
from
56dffde to
017cf6c
Compare
Screen.Recording.2024-12-10.at.9.24.52.AM.movI think it now works the way you mentioned @benjthayer ;)
Fixed, I bring in the sticky header after a bit of padding.
I cant see it in design, but I tried some playing with FastBlur and it looks like this Screen.Recording.2024-12-09.at.10.45.24.PM.mov
Fixed
Done. 
Improved now
Fixed
Fixed in this task #16834 |
…simple send fixes #16918
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
from
98aeb7e to
16e67a2
Compare
alexjba
reviewed
Dec 13, 2024
|
|
||
| loading: loadingCheckbox.checked | ||
|
|
||
| onReviewSendClicked: console.log("review send clicked") |
There was a problem hiding this comment.
nitpick: The Logs and LogsAndControlsPanel components are not really used. Did you mean to log this in the LogsAndControlsPanel? Otherwise just a simple panel would do. Same on all pages
| @@ -32,7 +33,8 @@ Dialog { | |||
| anchors.centerIn: Overlay.overlay | |||
|
|
|||
| padding: 16 | |||
| margins: 64 | |||
| // by design | |||
| margins: root.contentItem.Window.window.height <= 780 ? 28: 64 | |||
There was a problem hiding this comment.
do we need an extensive regression on all modals? Should be harmless, but you never know :D
|
|
||
| import AppLayouts.Wallet.views 1.0 | ||
|
|
||
| Rectangle { |
There was a problem hiding this comment.
Would be nice to inherit a Control instead. Gives more freedom for styling or adapting this to different views.
| /** Output signal to request signing of the transaction **/ | ||
| signal reviewSendClicked() | ||
| /** Output signal to request fetching fees **/ | ||
| signal fetchFees() |
There was a problem hiding this comment.
I'd keep the SendModal as simple as possible and UI only. Meaning that it doesn't have additional logic like detecting when new fees are required.
If we detect this here, the fees responsibility will be split between two components:
- Send modal to detect when a new fee is required based on what the user changes in the UI
- Other component to aggregate the user input from the
SendModaland request the fees onfetchFeessignal.
Another way would be for the SendModal to become a simple form. Any change in the form can be handled by the user of the SendModal. As a result, the logic of updating the fees is transparently handled in a single place, outside of the SendModal.
WDYT?
| **/ | ||
| required property var flatNetworksModel | ||
| /** true if testnet mode is on **/ | ||
| required property var areTestNetworksEnabled |
There was a problem hiding this comment.
Suggested change
| required property var areTestNetworksEnabled | |
| required property bool areTestNetworksEnabled |
| required property var areTestNetworksEnabled | ||
| /** whether community tokens are shown in send modal | ||
| based on a global setting **/ | ||
| required property var showCommunityAssetsInSend |
There was a problem hiding this comment.
Suggested change
| required property var showCommunityAssetsInSend | |
| required property bool showCommunityAssetsInSend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16836
What does the PR do
This PR add some dummy components + some actual ones in order to fix a mechanism for the dialog sizing.
Please not even though the AccountSelector, TokenSelector and NetworkFilter are added in this PR they are not worked on completely yet and is still something that is WIP under Epic #16696
Please note this PR doesn't cover QML Units tests, I will work on them next.
The Recipient selector is only temporary one and not done yet TBD under #16916
Affected areas
SimpleSend.qml
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-12-04.at.7.14.49.PM.mov
Screen.Recording.2024-12-04.at.7.19.35.PM.mov
Screen.Recording.2024-12-08.at.11.21.18.PM.mov