Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MembersTabPanel): unbreak context menu #16375

Conversation

caybro
Copy link
Member

@caybro caybro commented Sep 20, 2024

What does the PR do

  • restore backwards compatibility; a lot of the actions in the component relies on the old StatusListItem's title property to work correctly
  • fixes the missing image and name in the profile context menu, among others

Fixes #16367

Affected areas

Community/Settings/Members

Architecture compliance

  • I am familiar with the application architecture and agreed good practices.
    My PR is consistent with this document: Architecture guidelines

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

image

- restore backwards compatibility; a lot of the actions in the component
relies on the old StatusListItem's `title` property to work correctly
- fixes the missing image and name in the profile context menu, among
others

Fixes #16367
@status-im-auto
Copy link
Member

status-im-auto commented Sep 20, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8752249 #1 2024-09-20 18:06:29 ~6 min tests/nim 📄log
✔️ 8752249 #1 2024-09-20 18:08:55 ~8 min macos/aarch64 🍎dmg
✔️ 8752249 #1 2024-09-20 18:11:52 ~11 min macos/x86_64 🍎dmg
✔️ 8752249 #1 2024-09-20 18:12:00 ~11 min tests/ui 📄log
✔️ 8752249 #1 2024-09-20 18:14:42 ~14 min linux-nix/x86_64 📦tgz
✔️ 8752249 #1 2024-09-20 18:16:12 ~16 min linux/x86_64 📦tgz

@status-im-auto
Copy link
Member

@caybro caybro merged commit 4206617 into master Sep 23, 2024
9 checks passed
@caybro caybro deleted the 16367-profile-context-menu-opened-in-community-settings-does-not-show-image-or-name branch September 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile context menu opened in community settings does not show image or name
4 participants