Fix/payment request fixes #16936
Merged
Fix/payment request fixes #16936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
micieslak,
caybro and
alexjba
as code owners
Jenkins Builds
|
caybro
reviewed
Dec 11, 2024
| asset.name: Constants.tokenIcon(root.symbol) | ||
| } | ||
| } | ||
| contentItem: GridLayout { |
There was a problem hiding this comment.
I don't quite get why you need the GridLayout here?
There was a problem hiding this comment.
Somehow I got text to be rendered. Otherwise it won't render the text.
This was
linked to
issues
Dec 11, 2024
Closed
|
it fixes the linked issues |
anastasiyaig
approved these changes
Dec 11, 2024
jrainville
reviewed
Dec 11, 2024
caybro
approved these changes
Dec 12, 2024
|
@Cuteivist can you cherry-pick to master. Thanks |
|
@jrainville Emil is preparing proper fix for master, it wont be a cherry pick but new implementation |
Ah right. Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Affected areas
Chat / Payment Request modal
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Impact on end user
No glitches and wrong formatting for payment requests
How to test
Add payment request to status input and send it
Payment request
Risk
Described potential risks and worst case scenarios.
Tick one: