Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): Open Send modal from payment request #16945

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cuteivist
Copy link
Contributor

Closes #16738

What does the PR do

Affected areas

Chat / Send modal

Architecture compliance

Screenshot of functionality (including design for comparison)

open_send_modal_from_payment_request.mov

Impact on end user

Send modal can be opened from payment request again.

How to test

  • How should one proceed with testing this PR.
    Open send modal by clicking payment request
  • What kind of user flows should be checked?
    Payment request

Risk

Described potential risks and worst case scenarios.

Tick one:

  • Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
  • High risk: QA team MUST perform additional testing in the specified affected areas before merging.

@status-im-auto
Copy link
Member

status-im-auto commented Dec 12, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dc0f7da #1 2024-12-12 07:54:50 ~6 min macos/aarch64 🍎dmg
✔️ dc0f7da #1 2024-12-12 07:57:03 ~8 min tests/nim 📄log
✔️ dc0f7da #1 2024-12-12 07:59:45 ~11 min tests/ui 📄log
✔️ dc0f7da #1 2024-12-12 08:05:24 ~16 min macos/x86_64 🍎dmg
✔️ dc0f7da #1 2024-12-12 08:07:59 ~19 min linux-nix/x86_64 📦tgz
✔️ dc0f7da #1 2024-12-12 08:09:24 ~21 min linux/x86_64 📦tgz
✔️ dc0f7da #1 2024-12-12 08:17:35 ~29 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request Payment - open send modal
3 participants