-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup a merging queue with commit message checks #5610
Comments
cc @siddarthkay do you think it's possible to implement? |
Seems doable. I'll take a stab at this. |
Hmm. Can we make the merge queue at least for |
currently testing this on a small repo, I'll get back to you with more info. |
@siddarthkay this is actually important on our way of proper work with breaking changes. |
Problem
Recently we merged #5596 with
Squash and Merge
feature. It formed this f05b7e7 with message:And now all PR's on top of it are not passing the commit message check:
https://ci.status.im/blue/organizations/jenkins/status-go%2Fprs%2Ftests/detail/PR-5608/2/pipeline/
Solution
We need to ensure that suqash/merge commits also have proper message.
I believe merging queue should help us with this. No need to run the whole CI, just the commit message check.
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue
The text was updated successfully, but these errors were encountered: