Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commit_check)_: release branch commit check #5699

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Aug 12, 2024

This will fix the lock in PR like in #5697.
image

Also would be super-cool to implement this #5610. Then we'll just not have any bad-formed commit messages.


It's green on CI now.

PR for release/0.182.x branch:

[2024-08-12T21:30:03.364Z] bash _assets/scripts/commit_check.sh
[2024-08-12T21:30:03.364Z] Configuring Nix shell for target 'default'...
[2024-08-12T21:30:06.685Z] checking commits between: origin/release/0.182.x HEAD
[2024-08-12T21:30:06.685Z] false

PR for develop branch:

[2024-08-12T21:35:24.158Z] bash _assets/scripts/commit_check.sh
[2024-08-12T21:35:24.158Z] Configuring Nix shell for target 'default'...
[2024-08-12T21:35:27.345Z] checking commits between: origin/develop HEAD
[2024-08-12T21:35:27.345Z] false

@igor-sirotin igor-sirotin force-pushed the fix/release-branch-commit-check branch from 630fead to d404d32 Compare August 12, 2024 21:28
@igor-sirotin igor-sirotin changed the base branch from release/0.182.x to develop August 12, 2024 21:28
@igor-sirotin igor-sirotin changed the base branch from develop to release/0.182.x August 12, 2024 21:28
@status-im-auto
Copy link
Member

status-im-auto commented Aug 12, 2024

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 630fead #1 2024-08-12 21:29:01 ~1 min tests 📄log
✔️ 630fead #1 2024-08-12 21:30:07 ~2 min tests-rpc 📄log
✔️ 630fead #1 2024-08-12 21:31:26 ~3 min linux 📦zip
✔️ 630fead #1 2024-08-12 21:32:57 ~5 min android 📦aar
✔️ 630fead #1 2024-08-12 21:33:50 ~6 min ios 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d404d32 #2 2024-08-12 21:32:36 ~2 min tests-rpc 📄log
✔️ d404d32 #2 2024-08-12 21:33:57 ~2 min linux 📦zip
✔️ c22936f #3 2024-08-12 21:35:00 ~2 min tests-rpc 📄log
✔️ c22936f #2 2024-08-12 21:35:28 ~2 min android 📦aar
✔️ c22936f #3 2024-08-12 21:36:23 ~2 min linux 📦zip
✔️ c22936f #2 2024-08-12 21:41:07 ~5 min ios 📦zip
✔️ c22936f #3 2024-08-12 22:28:11 ~46 min tests 📄log

@igor-sirotin igor-sirotin merged commit f0b6e3d into release/0.182.x Aug 12, 2024
7 checks passed
@igor-sirotin igor-sirotin deleted the fix/release-branch-commit-check branch August 12, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants