Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telem)_: track total waku message bandwidth #6157

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

adklempner
Copy link
Contributor

@adklempner adklempner commented Dec 3, 2024

Tracks the size of every message sent over Waku using telemetry

If node is started with telemetry enabled:

  • starts Waku messenger with MessageSent event enabled. this instructs go-waku to emit an event in the eventbus each time a message is sent
  • listens for MessageSent events and sends them to telemetry

Also updates go-waku to latest version

Important changes:

Closes #

@status-im-auto
Copy link
Member

status-im-auto commented Dec 3, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f0726b3c #1 2024-12-03 01:30:48 ~4 min macos 📦zip
✔️ f0726b3c #1 2024-12-03 01:31:05 ~4 min ios 📦zip
✔️ f0726b3c #1 2024-12-03 01:31:24 ~5 min linux 📦zip
✔️ f0726b3c #1 2024-12-03 01:31:34 ~5 min android 📦aar
✔️ f0726b3c #1 2024-12-03 01:31:36 ~5 min tests-rpc 📄log
✔️ f0726b3c #1 2024-12-03 01:32:00 ~5 min windows 📦zip
✔️ f0726b3c #1 2024-12-03 01:34:08 ~7 min macos 📦zip
✖️ f0726b3c #1 2024-12-03 01:57:03 ~30 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cd3fe37 #2 2024-12-03 01:48:48 ~3 min windows 📦zip
✔️ cd3fe37 #2 2024-12-03 01:49:27 ~4 min macos 📦zip
✔️ cd3fe37 #2 2024-12-03 01:49:35 ~4 min tests-rpc 📄log
✔️ cd3fe37 #2 2024-12-03 01:49:41 ~4 min ios 📦zip
✔️ cd3fe37 #2 2024-12-03 01:49:52 ~4 min linux 📦zip
✔️ cd3fe37 #2 2024-12-03 01:50:19 ~5 min android 📦aar
✔️ cd3fe37 #2 2024-12-03 01:52:46 ~7 min macos 📦zip
✔️ cd3fe37 #2 2024-12-03 02:27:53 ~30 min tests 📄log
✔️ 31fb8f7 #3 2024-12-03 23:21:59 ~4 min windows 📦zip
✔️ 31fb8f7 #3 2024-12-03 23:22:19 ~4 min macos 📦zip
✔️ 31fb8f7 #3 2024-12-03 23:22:20 ~4 min linux 📦zip
✔️ 31fb8f7 #3 2024-12-03 23:22:31 ~4 min ios 📦zip
✔️ 31fb8f7 #3 2024-12-03 23:22:34 ~4 min tests-rpc 📄log
✔️ 31fb8f7 #3 2024-12-03 23:22:56 ~5 min android 📦aar
✔️ 31fb8f7 #3 2024-12-03 23:25:19 ~7 min macos 📦zip
✔️ 31fb8f7 #3 2024-12-03 23:47:45 ~29 min tests 📄log

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (8a7f24b) to head (31fb8f7).
Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
wakuv2/waku.go 54.54% 4 Missing and 1 partial ⚠️
telemetry/client.go 81.81% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6157      +/-   ##
===========================================
+ Coverage    60.98%   61.08%   +0.10%     
===========================================
  Files          827      827              
  Lines       109779   109798      +19     
===========================================
+ Hits         66945    67070     +125     
+ Misses       34988    34870     -118     
- Partials      7846     7858      +12     
Flag Coverage Δ
functional 14.17% <0.00%> (-0.04%) ⬇️
unit 60.08% <68.18%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
telemetry/client.go 73.39% <81.81%> (+0.28%) ⬆️
wakuv2/waku.go 68.55% <54.54%> (-0.23%) ⬇️

... and 37 files with indirect coverage changes

@adklempner adklempner force-pushed the feat/telem-message-bandwidth branch from cd3fe37 to 31fb8f7 Compare December 3, 2024 23:17
@adklempner adklempner marked this pull request as ready for review December 4, 2024 00:06
@adklempner adklempner requested a review from a team December 5, 2024 20:46
@adklempner adklempner merged commit e7cc535 into develop Dec 6, 2024
19 checks passed
@adklempner adklempner deleted the feat/telem-message-bandwidth branch December 6, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants