chore(logging)_: default waku node logs to INFO level #6164
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (49)
|
igor-sirotin
approved these changes
Dec 3, 2024
wakuv2/persistence/dbstore.go
Outdated
| @@ -200,7 +200,7 @@ func (d *DBStore) Query(query *storepb.HistoryQuery) (*storepb.Index, []gowakuPe | |||
| start := time.Now() | |||
| defer func() { | |||
| elapsed := time.Since(start) | |||
| d.log.Info(fmt.Sprintf("Loading records from the DB took %s", elapsed)) | |||
| d.log.Debug(fmt.Sprintf("Loading records from the DB took %s", elapsed)) | |||
There was a problem hiding this comment.
Suggested change
| d.log.Debug(fmt.Sprintf("Loading records from the DB took %s", elapsed)) | |
| d.log.Debug("loaded records from DB", zap.Duration("duration", elapsed)) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6164 +/- ##
============================================
+ Coverage 13.90% 60.96% +47.05%
============================================
Files 817 832 +15
Lines 108265 109836 +1571
============================================
+ Hits 15054 66959 +51905
+ Misses 91290 35042 -56248
- Partials 1921 7835 +5914
Flags with carried forward coverage won't be shown. Click here to find out more.
|
osmaczko
force-pushed
the
chore/reduce-waku-logs-spam
branch
2 times, most recently
from
0148d3d to
566e9e1
Compare
osmaczko
force-pushed
the
chore/reduce-waku-logs-spam
branch
from
566e9e1 to
0338f04
Compare
osmaczko
changed the base branch from
develop
to
feat/integrate-categorized-logging
osmaczko
changed the title
|
cc: @ilmotta as it's gonna be necessary to add a checkbox or something in mobile to enable waku debug level logs with |
ilmotta
reviewed
Dec 4, 2024
| @@ -289,7 +289,7 @@ func New(nodeKey *ecdsa.PrivateKey, fleet string, cfg *Config, logger *zap.Logge | |||
| node.WithConnectionNotification(waku.connectionNotifChan), | |||
| node.WithTopicHealthStatusChannel(waku.topicHealthStatusChan), | |||
| node.WithKeepAlive(randomPeersKeepAliveInterval, allPeersKeepAliveInterval), | |||
| node.WithLogger(logger), | |||
| node.WithLogger(logger.Named("wakunode")), | |||
There was a problem hiding this comment.
Would be nice to refer to namespaces we need to hardcode using constants.
|
Issue created for Mobile status-im/status-mobile#21758. Thanks for tagging me @richard-ramos |
igor-sirotin
approved these changes
Dec 4, 2024
Base automatically changed from
feat/integrate-categorized-logging
to
develop
December 5, 2024 14:19
osmaczko
force-pushed
the
chore/reduce-waku-logs-spam
branch
from
0338f04 to
c7e3c34
Compare
This ensures waku node logs remain at INFO level, even if the global
logging level is set lower (e.g. DEBUG). To enable waku logs at a
specific level, one can execute:
`wakuext_setLogNamespaces([{"logNamespaces": "wakunode:debug"}])`.
iterates: status-im/status-desktop#16511
osmaczko
force-pushed
the
chore/reduce-waku-logs-spam
branch
from
c7e3c34 to
61c9e83
Compare
ilmotta
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures waku node logs remain at INFO level, even if the global
logging level is set lower (e.g. DEBUG). To enable waku logs at a
specific level, one can execute:
wakuext_setLogNamespaces([{"logNamespaces": "wakunode:debug"}]).iterates: status-im/status-desktop#16511