-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_: set proxy creds #6211
base: develop
Are you sure you want to change the base?
test_: set proxy creds #6211
Conversation
Jenkins BuildsClick to see older builds (8)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6211 +/- ##
===========================================
- Coverage 61.27% 60.07% -1.20%
===========================================
Files 833 833
Lines 109910 109910
===========================================
- Hits 67348 66032 -1316
- Misses 34711 36121 +1410
+ Partials 7851 7757 -94
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antdanchenko this also needs to be set in LoginAccount
:
status-go/tests-functional/clients/status_backend.py
Lines 180 to 187 in 1795620
def login(self, keyUid, user=user_1): | |
method = "LoginAccount" | |
data = { | |
"password": user.password, | |
"keyUid": keyUid, | |
"kdfIterations": 256000, | |
} |
status-go/protocol/requests/login.go
Line 36 in b74d9e6
WalletSecretsConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
We require commits to follow the Conventional Commits, but with
|
Closes #6144