Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet Activity: Use wallet_startActivityFilterSession RPC instead of wallet_filterActivityAsync #21583

Open
smohamedjavid opened this issue Nov 5, 2024 · 0 comments · May be fixed by #21596
Open

Wallet Activity: Use wallet_startActivityFilterSession RPC instead of wallet_filterActivityAsync #21583

smohamedjavid opened this issue Nov 5, 2024 · 0 comments · May be fixed by #21596
Assignees
@smohamedjavid
Labels
feature feature requests
Milestone
2.32.0

Comments

@smohamedjavid
Copy link
Member

Feature Issue

User Story

As a developer, I want to use the latest RPC used by other clients so that mobile will stay updated with any RPC changes.

Description

  • The existing wallet_filterActivityAsync RPC is deprecated and the mobile has to update to the new wallet_startActivityFilterSession RPC
  • This issue involves adding the wallet_getMoreForActivityFilterSession RPC to fetch more activities as the user scrolls and the wallet_stopActivityFilterSession RPC to stop the session when the user moves away from the activity tab

Acceptance Criteria

The activity works as before
@smohamedjavid smohamedjavid added the feature feature requests label Nov 5, 2024
@smohamedjavid smohamedjavid added this to the 2.32.0 milestone Nov 5, 2024
@smohamedjavid smohamedjavid self-assigned this Nov 5, 2024
@smohamedjavid smohamedjavid linked a pull request Nov 6, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smohamedjavid smohamedjavid

Labels
feature feature requests
Projects
Status Desktop/Mobile Board
Status: No status
Milestone
2.32.0
1 participant
@smohamedjavid