[WIP] Wallet Activity: Remove deprecated RPCs and use activity filter session RPC #21596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
Signed-off-by: Mohamed Javid <[email protected]>
smohamedjavid
force-pushed
the
chore/activity-rpc-cleanup
branch
from
540d649
to
e3409e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21583
Summary
This PR:
wallet_filterActivityAsyncRPC and updates it towallet_startActivityFilterSessionwith other supporting activity filter session RPCswallet_checkRecentHistoryForChainIDsRPC as we no longer support past transaction historyReview notes
This PR will be open to review or testing once we move to the new transaction RPC flow, as the activities depend on it.
Platforms
Steps to test
status: WIP