Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat_: add fallback pairing support #20921

Merged
merged 1 commit into from
Jul 30, 2024
Merged

feat_: add fallback pairing support #20921

merged 1 commit into from
Jul 30, 2024

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Jul 30, 2024 •
edited
Loading

Creating this PR for regression testing the comparability of feature sync between different versions(mainly current PR build vs v2.29) after adding backend fallback pairing support. Because frontend haven't added the invocations relate to fallback pairing API yet, so fallback pairing won't support with current build.

relate status-go PR

Testing notes

expected: sync should work as before between different versions like following:
v2.29 <-> PR build
PR build <-> recent desktop build

NOTE: It breaks with v1 of pairing, but that's ancient (last year I believe), so safe to break.

status: ready

@qfrank qfrank self-assigned this Jul 30, 2024
@qfrank qfrank mentioned this pull request Jul 30, 2024
Merged
@status-im-auto
Copy link
Member

status-im-auto commented Jul 30, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 047a1c7 #1 2024-07-30 12:09:25 ~5 min tests 📄log
✔️ 047a1c7 #1 2024-07-30 12:10:54 ~6 min android-e2e 🤖apk 📲
✔️ 047a1c7 #1 2024-07-30 12:12:32 ~8 min android 🤖apk 📲
✔️ 047a1c7 #1 2024-07-30 12:14:41 ~10 min ios 📱ipa 📲
✔️ d3238be #2 2024-07-30 18:50:23 ~4 min tests 📄log
✔️ d3238be #2 2024-07-30 18:53:31 ~7 min android-e2e 🤖apk 📲
✔️ d3238be #2 2024-07-30 18:54:39 ~8 min android 🤖apk 📲
✔️ d3238be #2 2024-07-30 18:55:35 ~9 min ios 📱ipa 📲

@VolodLytvynenko VolodLytvynenko self-assigned this Jul 30, 2024
@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 51
Failed tests: 6
Expected to fail tests: 1
Passed tests: 44

IDs of failed tests: 702958,702775,704613,703133,703503,702777 

IDs of expected to fail tests: 727232

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777

    Device 2: Tap on found: Button
    Device 2: Find `Button` by `xpath`: `//*[@text="Continue" or @text="CONTINUE"]` 

    activity_center/test_activity_center.py:222: in test_add_contact_field_validation
    sync_code = self.profile_2.get_sync_code()
../views/profile_view.py:547: in get_sync_code
    self.continue_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[@text="Continue" or @text="CONTINUE"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958

    Device 2: Clearing history in chat 'user1' by long press
    Device 2: Looking for chat: 'user1' 

    activity_center/test_activity_center.py:458: in test_activity_center_admin_notification_accept_swipe
    self.home_2.clear_chat_long_press(self.username_1)
../views/home_view.py:552: in clear_chat_long_press
    self.get_chat(username).long_press_element()
../views/home_view.py:374: in get_chat
    if not chat_element.is_element_displayed(wait_time) and community is False and community_channel is False:
../views/base_element.py:221: in is_element_displayed
    return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
../views/base_element.py:145: in wait_for_visibility_of_element
    .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:86: in until
    value = method(self._driver)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:152: in _predicate
    return _element_if_visible(driver.find_element(*locator))
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:175: in _element_if_visible
    return element if element.is_displayed() == visibility else False
 'dict' object has no attribute 'is_displayed'



    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775

    Device 1: Waiting 35s for dapp to load
    Device 1: Find Text by accessibility id: community-title 

    critical/test_deep_and_universal_links.py:112: in test_links_deep_links
    if self.community_view.community_title.text != text:
../views/base_element.py:419: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by accessibility id: `community-title` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/ixyACjgKDVNOVCBjb21tdW5pdHkSHHJlcXVpcmUgMTAgU05UIEdvZXJsaSB0byB1c2UYASIHI2VhYjcwMAM=#zQ3shUeGnhM33QW4g9JfYfeLFAH9ZwbDboNYn5exCR7S3ii1y')]
    Device 1: Find Text by accessibility id: community-title 

    critical/test_deep_and_universal_links.py:64: in test_links_open_universal_links_from_chat
    if self.community_view.community_title.text != text:
../views/base_element.py:419: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by accessibility id: `community-title` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Could not reach home view by pressing system back button
    Device 1: Find CommunitiesTab by accessibility id: communities-stack-tab 

    critical/chats/test_public_chat_browsing.py:223: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.home.communities_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: CommunitiesTab by accessibility id: `communities-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_community_discovery, id: 703503

    # STEP: Turn off testnet in the profile settings
    Device 1: Find ChatsTab by accessibility id: chats-stack-tab 

    critical/chats/test_public_chat_browsing.py:255: in test_community_discovery
    profile = self.home.profile_button.click()
../views/base_view.py:154: in click
    ChatsTab(self.driver).click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Find EditBox by accessibility id: add-address-to-watch
    Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox 

    critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

    [[Missing networks in account address, https://github.com//issues/20166]]

    Device sessions

    Passed tests (44)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    4. test_group_chat_pin_messages, id: 702732
    Device sessions

    5. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    6. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    @VolodLytvynenko
    Copy link
    Contributor

    hi @qfrank thank you for PR. No issues from my side. PR is ready to be merged

    @ilmotta ilmotta mentioned this pull request Jul 30, 2024
    Merged
    @ilmotta ilmotta force-pushed the feature/fallback-pairing-seed2 branch from 047a1c7 to d3238be Compare July 30, 2024 18:45
    @ilmotta ilmotta merged commit 07cf34a into develop Jul 30, 2024
    5 checks passed
    @ilmotta ilmotta deleted the feature/fallback-pairing-seed2 branch July 30, 2024 19:08
    @ilmotta ilmotta mentioned this pull request Aug 20, 2024
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @Samyoul Samyoul Samyoul approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    Assignees

    @qfrank qfrank

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa status-go Tested - OK
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @qfrank @status-im-auto @VolodLytvynenko @ilmotta @Samyoul @Parveshdhull