☝️Point Go to 5807 #21281
Closed
☝️Point Go to 5807 #21281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
|
Hey @shivekkhurana, thank you for the PR. The e2e and android builds have failed #21281 (comment). Could you take a look please |
|
It was probably because of not having the correct commit hash (I used PR number for Go). I have pushed a change, please try again and lmk if it works this time. |
53% of end-end tests have passedFailed tests (24)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Passed tests (27)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
|
|
From what I've seen swaps shouldn't been affected as deprecated methods are still available, but I'll spend some time today to test this locally |
82% of end-end tests have passedFailed tests (9)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Passed tests (42)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
|
hi @shivekkhurana The issue is not fixed in current PR. Still reproducible |
|
Issue with error "eq() not a number: <0.01" is still reproducible as well |
|
The issue related to closing the keyboard is also reproducible |
67% of end-end tests have passedFailed tests (3)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (6)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
|
|
Hi @shivekkhurana, thank you for the PR. No other issues from my side. I didn’t notice any visual improvements - existing issues still remain, and I didn't find any new ones either. If this is the expected result, then the PR can be merged |
33% of end-end tests have passedFailed tests (2)Click to expandClass TestWalletMultipleDevice:
Passed tests (1)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
I'll close this PR then, as we do not require bump of version, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a placeholder to test changes made to Status Go in this PR -> status-im/status-go#5807
Testing notes
There are notes on changes about the fix on Desktop client, we need to check the paths outlined there
status-im/status-desktop#16330
Known issues
There were 6 regressions introduced in the last PR that improved the router. We are not sure if it was Status Go changes or client issues, but they issues still exist, and might be reflected while testing this PR.
If you face one of the 6 issues referred in this PR, just refer to the existing issue. If there are new issues, we can follow the process as usual and ask Desktop to fix the problems in that PR itself.
Time sensitivity
Since this is a cross team issue, it's important to be mindful of time. The last time, the router cleanup issues were dragged for sometime (which is my fault as I couldn't pick up and delegate them). Let's try better this time.