Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21557] feat: show from account page in swap flow #21611

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Nov 12, 2024

fixes #21557

Summary

The "From" page should appear, allowing the user to choose the account for the swap.

Areas that maybe impacted

  • Swap flow when user has multiple account

Steps to test

  1. Ensure user has at least 2 accounts set up.
  2. Go to the wallet main page.
  3. Tap on "Swap" for any asset.

Result

Simulator.Screen.Recording.-.iPhone.13.-.2024-11-13.at.23.25.52.mp4

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Nov 12, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Nov 12, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d516016 #1 2024-11-12 10:18:17 ~5 min tests 📄log
✔️ d516016 #1 2024-11-12 10:22:02 ~9 min android-e2e 🤖apk 📲
✔️ d516016 #1 2024-11-12 10:22:20 ~9 min ios 📱ipa 📲
✔️ d516016 #1 2024-11-12 10:22:33 ~9 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d730706 #2 2024-11-13 20:25:04 ~4 min tests 📄log
✔️ d730706 #2 2024-11-13 20:28:56 ~8 min android-e2e 🤖apk 📲
✔️ d730706 #2 2024-11-13 20:29:11 ~8 min ios 📱ipa 📲
✔️ d730706 #2 2024-11-13 20:29:36 ~9 min android 🤖apk 📲
✔️ f2900c3 #3 2024-11-13 20:39:43 ~4 min tests 📄log
✔️ f2900c3 #3 2024-11-13 20:43:55 ~8 min ios 📱ipa 📲
✔️ f2900c3 #3 2024-11-13 20:43:56 ~8 min android-e2e 🤖apk 📲
✔️ f2900c3 #3 2024-11-13 20:44:26 ~9 min android 🤖apk 📲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

"From" page with list of accounts not displayed when tapping swap on wallet main page with multiple accounts
2 participants