Skip to content

Conversation

yqrashawn
Copy link

@yqrashawn yqrashawn commented Jun 16, 2025

this PR is based on PR #704, please merge #704 before this one

resolve the none UI part of #698

Note

  • password validation requires password and walletId, which means this can't be used for unlocking the wallet if walletId is encrypted as well

Todo

  • when there's both walletId and password, validate the pwd and add a validPassword to ctx if password is valid (using keystore export for validation)
  • check validPassword before using it with keystore in other procedures

Copy link

changeset-bot bot commented Jun 16, 2025

🦋 Changeset detected

Latest commit: aa64eca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@status-im/trpc-webext Patch
wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 16, 2025

@yqrashawn is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@status-im-auto
Copy link
Member

status-im-auto commented Jun 16, 2025

Jenkins Builds

Click to see older builds (3)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3755616 #1 2025-06-16 02:18:15 ~51 sec wallet 📦zip
✔️ ba88ad5 #2 2025-06-17 01:45:53 ~53 sec wallet 📦zip
✔️ ba88ad5 #4 2025-07-14 01:24:45 ~47 sec wallet 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 893ec93 #5 2025-07-14 01:35:37 ~1 min wallet 📦zip
✔️ aa64eca #6 2025-07-14 01:37:03 ~54 sec wallet 📦zip

@yqrashawn yqrashawn force-pushed the feat/password-auth branch from 3755616 to ba88ad5 Compare June 17, 2025 01:44
@yqrashawn yqrashawn changed the title feat: password auth [WIP] feat: password validation (no UI) Jun 18, 2025
@yqrashawn yqrashawn force-pushed the feat/password-auth branch from ba88ad5 to b29aa04 Compare June 29, 2025 23:18
@yqrashawn yqrashawn force-pushed the feat/password-auth branch 2 times, most recently from ba88ad5 to 893ec93 Compare July 14, 2025 01:34
@yqrashawn yqrashawn force-pushed the feat/password-auth branch from 893ec93 to aa64eca Compare July 14, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants