-
Notifications
You must be signed in to change notification settings - Fork 45
add wallet connect #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add wallet connect #804
Conversation
🦋 Changeset detectedLatest commit: 97b3a75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we reuse apps/portfolio integration and ensure it works for both by running side-by-side?
Jenkins BuildsClick to see older builds (4)
|
0f755a5
to
3697f43
Compare
@@ -1,6 +1,6 @@ | |||
{ | |||
"$schema": "https://openapi.vercel.sh/vercel.json", | |||
"ignoreCommand": "git diff --quiet HEAD^ HEAD ../../{patches,package.json,turbo.json} ../../packages/{colors,icons} ./", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First manually triggered the build. And then added these dependencies.
Add wallet connect functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this should be a util function rather than a component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reused component from different project, we use it as a component so I'd keep it for consistency, even though you are right and it could work just as a util function, but there's export of util function as well in case you need it.
99fde63
to
f2e7acf
Compare
closes #764