Skip to content

Conversation

jkbktl
Copy link
Contributor

@jkbktl jkbktl commented Sep 19, 2025

closes #764

Copy link

changeset-bot bot commented Sep 19, 2025

🦋 Changeset detected

Latest commit: 97b3a75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@status-im/status-network Patch
hub Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
status-network-hub Ready Ready Preview Comment Oct 7, 2025 4:00pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
status-api Ignored Ignored Preview Oct 7, 2025 4:00pm
status-components Ignored Ignored Preview Oct 7, 2025 4:00pm
status-portfolio Ignored Ignored Preview Oct 7, 2025 4:00pm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we reuse apps/portfolio integration and ensure it works for both by running side-by-side?

@status-im-auto
Copy link
Member

status-im-auto commented Sep 23, 2025

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0f755a5 #2 2025-09-23 21:33:35 ~34 sec connector 📦zip
✔️ 0f755a5 #2 2025-09-23 21:34:03 ~1 min wallet 📦zip
✔️ 74efb1f #5 2025-09-25 15:32:55 ~35 sec connector 📦zip
74efb1f #5 2025-09-25 15:32:56 ~36 sec wallet 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fb55c94 #6 2025-09-25 16:05:28 ~33 sec connector 📦zip
✔️ fb55c94 #6 2025-09-25 16:06:06 ~1 min wallet 📦zip
6346e55 #7 2025-09-30 21:05:39 ~16 sec wallet 📄log
6346e55 #7 2025-09-30 21:05:39 ~16 sec connector 📄log

@@ -1,6 +1,6 @@
{
"$schema": "https://openapi.vercel.sh/vercel.json",
"ignoreCommand": "git diff --quiet HEAD^ HEAD ../../{patches,package.json,turbo.json} ../../packages/{colors,icons} ./",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First manually triggered the build. And then added these dependencies.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should be a util function rather than a component.

Copy link
Contributor Author

@jkbktl jkbktl Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reused component from different project, we use it as a component so I'd keep it for consistency, even though you are right and it could work just as a util function, but there's export of util function as well in case you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

add wallet connecting
4 participants