issue48_bugfix #53
Open
issue48_bugfix #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 25, 2017
index.js
Outdated
| @@ -81,6 +83,10 @@ function executeFlow(_path, options) { | |||
| dat += data.toString(); | |||
| }); | |||
|
|
|||
| stream.stderr.on('data', function (error) { | |||
| dat = error.toString('utf8'); | |||
| }) | |||
|
Awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zap guys
This solves the problem of outputing that the check passed when in fact no checking was made.
Actually it only catches errors containing "unsupported" on the message in this fix, which happens when an unknown tag is used in .flowconfig. In my case, I was trying to use [lints] [strict], which aren't supported in the peerDep version the project uses of flow-bin.
Being so, this is also a suggestion to update the flow-bin version, which would have fixed my problem in the first place.