Add double-factorial implementation #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Oct 23, 2023
kgryte
added
Feature
|
As discussed with regard to extension to complex numbers (https://en.wikipedia.org/wiki/Double_factorial#Extensions), the gamma approximation does not agree for even integers. As such, I am inclined to think we should stick with the "classic" definition. We could, in theory, extend to negative integers; however, I don't think there's an immediate use case, so leaving as restricted to nonnegative integers, seems fine with me. |
|
Additionally, I think that manually re-computing via a loop is fine. A look-up table would likely be a bit faster; however, a static table would significantly increase bundle sizes for what is likely to be a function which is not heavily used. |
This commit adds license to test.js per project requirements.
This commit (1) edits code to conform to style guide; changes 'let' to 'var', and returns NaN for bad input.
This commit fixes typo in variable name and edits to conform to style guide.
This commit deletes unused decimals code in benchmark.
As stated in short message.
This commit adds in repl.txt, a standard file not included when project was started.
As stated above.
To stop git from listing files as untraced in ../factorial directory.
no-verify commit per A. Reines as typescript linter is to be replaced.
This commit moves README.md from the wrong directory and corrects some lint errors.
Restore after inadvertently deleting.
This commit adds integers.json, used for testing factorial2. NB these values are not from Julia but hand calculated.
This file is copied and adapted from factorial directory.
As stated in commit header.
This commit corrects an error as said file should not have been in this directory in the first place.
Had added .gitignore but not needed all derived from inadvertent copying of files into wrong directory.
Decimals are removed as the input values are always expected to be integers, and, similarly, the return values for input values within range are also expected to be integers.
kgryte
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44 .
Description
This pull request:
Related Issues
This pull request:
Questions
Should the implementation be extended to include all reals? Complex numbers?
Other
Prior art:
Checklist
@stdlib-js/reviewers