Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamming distance between two strings (Compares Unicode code points) #1759

Closed
wants to merge 23 commits into from
Closed

Hamming distance between two strings (Compares Unicode code points) #1759

wants to merge 23 commits into from

Conversation

JayPokale
Copy link

@JayPokale JayPokale commented Mar 7, 2024 •
edited by kgryte
Loading

Description

Calculates the Hamming Code Points Distance distance between two equal-length unicode code points.

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

JayPokale added 11 commits March 7, 2024 22:52
@JayPokale
Create benchmark.js
40f8869 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Create index.d.ts
77b4c59 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Create test.ts
8d858cf 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Create repl.txt
6b47c2e 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Create index.js
f35d58e 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Create index.js
f80b367 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Create main.js
40e0db8 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Create test.js
06569bc 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Create package.json
4bc8dfe 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Create README.md
4aa64dd 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Update CONTRIBUTORS
396c955 
Signed-off-by: Jay Pokale <[email protected]>
stdlib-bot
stdlib-bot reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@JayPokale JayPokale mentioned this pull request Mar 7, 2024
Open
7 tasks
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. JavaScript Issue involves or relates to JavaScript. Feature Issue or pull request for adding a new feature. labels Mar 7, 2024
@Pranavchiku
Copy link
Member

@JayPokale can you please ensure linters are set correctly in your device. I think those are not.

Pranavchiku
Pranavchiku suggested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through development guide and iterate through the PR you referred. Setup dev environment and then this PR can be reviewed.

CONTRIBUTORS Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/distances/hamming-code-points/benchmark/benchmark.js Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/distances/hamming-code-points/docs/types/test.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/distances/hamming-code-points/docs/types/test.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/distances/hamming-code-points/docs/types/test.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/distances/hamming-code-points/lib/index.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/distances/hamming-code-points/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/distances/hamming-code-points/lib/main.js Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/distances/hamming-code-points/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/distances/hamming-code-points/test/test.js Outdated Show resolved Hide resolved
@Pranavchiku Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 8, 2024
JayPokale added 10 commits March 11, 2024 15:06
@JayPokale
Merge pull request #2 from stdlib-js/develop
062e5a6 
Merge
@JayPokale
Update CONTRIBUTORS
c642034 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Update benchmark.js
ebaa56d 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Update benchmark.js
0946e34 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Update index.d.ts
34a3741 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Update test.ts
838eb85 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Update index.js
8ae1a58 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Update index.js
50d111f 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Update main.js
e125bb4 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Update test.js
fcda57d 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Hamming code points
ec1c648 
Signed-off-by: Jay Pokale <[email protected]>
@JayPokale
Copy link
Author

@Pranavchiku I converted code in required format as mentioned above.

@kgryte kgryte added Utilities Issue or pull request concerning general utilities. Needs Review A pull request which needs code review. and removed JavaScript Issue involves or relates to JavaScript. labels Mar 17, 2024
@kgryte
Copy link
Member

kgryte commented Mar 17, 2024

This PR is currently failing CI and needs to be updated before we can review.

@JayPokale JayPokale closed this Mar 18, 2024
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Pranavchiku Pranavchiku Pranavchiku requested changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JayPokale @Pranavchiku @kgryte @stdlib-bot @Planeshifter