Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/asecd #1788

Merged
merged 11 commits into from
Mar 11, 2024
Merged

feat: add math/base/special/asecd #1788

merged 11 commits into from
Mar 11, 2024

Conversation

the-r3aper7
Copy link
Contributor

@the-r3aper7 the-r3aper7 commented Mar 8, 2024 •
edited
Loading

Resolves #41

Description

What is the purpose of this pull request?

This pull request:

  • Adds functionality to compute asecd of any given input.
  • Say we have input x, so it should satisfies this x >= 1 or x <= -1 else it will return NaN.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. JavaScript Issue involves or relates to JavaScript. labels Mar 8, 2024
@the-r3aper7 the-r3aper7 changed the title feat: add math/base/special/asecd feat: add math/base/special/asecd Mar 9, 2024
@the-r3aper7
Update README.md
7408186 
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
@the-r3aper7
Update test.js
f290f8e 
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
@the-r3aper7
Update main.js
87b1c2c 
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
@the-r3aper7
Update main.js
be6d018 
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
Planeshifter
Planeshifter approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few documentation and code style updates; will merge once CI passes. Thanks!

lib/node_modules/@stdlib/math/base/special/asecd/package.json Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/asecd/package.json Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/asecd/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/asecd/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/asecd/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/asecd/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/asecd/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/asecd/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/asecd/docs/repl.txt Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/asecd/docs/repl.txt Outdated Show resolved Hide resolved
@Planeshifter Planeshifter merged commit 5b72836 into stdlib-js:develop Mar 11, 2024
7 checks passed
@the-r3aper7 the-r3aper7 deleted the asecd branch March 12, 2024 01:34
@the-r3aper7 the-r3aper7 mentioned this pull request Mar 15, 2024
Closed
5 tasks
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Mar 17, 2024
Closed
1 task
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement asecd
2 participants
@the-r3aper7 @Planeshifter