-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/acscd
#1789
Conversation
@the-r3aper7 we appreciate your contribution but opening 10 PRs in a span of 10 hour just don't make any sense. Also, it unnecessarily blocks other people to work on those. Neither of PR seems perfect to me, even description is not filled correctly. Reiterating we prefer quality of contribution over number of PRs. |
i am sorry, i will refactor them by today. i was just laying the foundation and I did not have intention to block other people work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@the-r3aper7 Left a few comments here upon cursory look through the package.
One important thing that should be added (here and in your other PRs) are tests showing that the function returns the correct values for valid inputs. You can generate a set of test values and add a test with description the function computes the arccosecant (in degrees)
to test.js
. Please have a look at other packages on how these are typically authored.
cool i will make changes to other PRs too. About tests part i have intentionally left those because I wanted to ask how can I generate that huge json file which have inputs. |
@Planeshifter i have made those changes! |
math/base/special/acscd
@Planeshifter i have made changes all the other PRs too. can you review those. |
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be almost ready to merge now. Thanks for updating!
lib/node_modules/@stdlib/math/base/special/acscd/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/acscd/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
cool i will make changes to other PRs. too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did one more look over the package; looks all good to me!
Will merge shortly.
Resolves #42 .
Description
This pull request:
acscd
in degree of any given input.x
, so it should satisfies thisx >= 1
orx <= -1
else it will returnNaN
Related Issues
This pull request:
acscd
#42Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers