Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add constants/float32/half-pi #1953

Merged
merged 6 commits into from
Mar 19, 2024
Merged

feat: add constants/float32/half-pi #1953

merged 6 commits into from
Mar 19, 2024

Conversation

gunjjoshi
Copy link
Member

Resolves a part of #1944

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/half-pi.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@gunjjoshi
Copy link
Member Author

This Pull request is a pre-requisite for #1944 and #1950.

This was referenced Mar 19, 2024
Closed
Closed
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Mar 19, 2024
kgryte
kgryte requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @gunjjoshi. Left a few comments.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Mar 19, 2024
@gunjjoshi
Copy link
Member Author

Thanks for the review @kgryte. I have made the suggested changes. Also, I have used float64ToFloat32, as being used at https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float32/sqrt-eps .
Also, I have changed the values of pi/2, and have used 1.5707963705062866 everywhere, and 1.5707963705062866f in half_pi.h.

Is this the correct way, any suggestions ?

@gunjjoshi
Update test.ts
50a3dae 
Signed-off-by: GUNJ JOSHI <[email protected]>
kgryte
kgryte approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte merged commit afb14b3 into stdlib-js:develop Mar 19, 2024
7 checks passed
kgryte pushed a commit that referenced this pull request Mar 21, 2024
@gunjjoshi
fix: rename include directory for constants/float32/half-pi
2bf94d2 
PR-URL: 	#1976
Ref: #1953
Reviewed-by: Athan Reines <[email protected]>
@gunjjoshi gunjjoshi deleted the float32-pi02f branch March 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunjjoshi @kgryte