Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/ahaversinf #3076

Merged
merged 9 commits into from
Nov 10, 2024

Conversation

aayush0325
Copy link
Contributor

Resolves #649.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Open to reviews!!

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 8, 2024
@aayush0325
Copy link
Contributor Author

ready for review @Planeshifter !

@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Nov 9, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @aayush0325! Left one comment concerning the implementation, otherwise this is looking good.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 9, 2024
@aayush0325
Copy link
Contributor Author

aayush0325 commented Nov 10, 2024

kindly let me know if i should add @stdlib/number/float64/base/to-float32 to manifest.json and what is the proper way to do it. I've made the requested changes, thank you for your time.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution and the changes! WIll merge shortly.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Nov 10, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `math/base/special/ahaversinf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3076
Closes: https://github.com/stdlib-js/stdlib/issues/649

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 545a050 into stdlib-js:develop Nov 10, 2024
18 checks passed
@aayush0325 aayush0325 deleted the ahaversinf branch November 11, 2024 01:03
aayush0325 added a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementations to base special math functions (tracking issue)
3 participants