-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/lucasf
#3348
base: develop
Are you sure you want to change the base?
Conversation
@aayush0325, available slash commands include:
|
Coverage Report
The above coverage report was generated for the changes in this PR. |
/stdlib update-copyright-years |
@aayush0325, slash command not recognized. Please use |
/stdlib update-copyright-years |
@aayush0325 Thanks for working on this. Can you please update both JS and C benchmarks to pre-compute the values, outside the loop? |
got it, pushing soon. |
pushed |
/stdlib merge |
good evening @gunjjoshi, this branch has been rebased to make use of |
lib/node_modules/@stdlib/math/base/special/lucasf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aayush0325 Can you update this file to use @stdlib/random/array/uniform
to generate random numbers beforehand, instead of using @stdlib/random/base/randu
?
|
||
# Lucas | ||
|
||
> Compute the nth [Lucas number][lucas-number] in single-precision floating-point format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> Compute the nth [Lucas number][lucas-number] in single-precision floating-point format. | |
> Compute the nth [Lucas number][lucas-number] in single-precision floating-point format. |
@aayush0325 Can you update this here and everywhere else in this PR, to use:
Compute/Computes the nth [Lucas number][lucas-number] as a single-precision floating-point number.
lib/node_modules/@stdlib/math/base/special/lucasf/examples/c/example.c
Outdated
Show resolved
Hide resolved
good afternoon @gunjjoshi. I've pushed the requested changes. However a linting error was stopping me from updating the description in |
@aayush0325 You don't have to use
while, for the rest files, we should use:
|
Ah, my bad. pushing the needed changes soon. |
Pushed, sorry for the misunderstanding. |
I don't get why this is failing the linting tests this seems to run fine locally on the dev container @gunjjoshi |
/stdlib merge |
/stdlib merge |
/stdlib merge |
#include "stdlib/math/base/napi/unary.h" | ||
|
||
// cppcheck-suppress shadowFunction | ||
STDLIB_MATH_BASE_NAPI_MODULE_I_F( stdlib_base_lucasf ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we have used STDLIB_MATH_BASE_NAPI_MODULE_I_D
in math/base/special/lucas
, we can use STDLIB_MATH_BASE_NAPI_MODULE_I_I
here and modify the function signature accordingly, as we have the API ready which accepts and returns an int32
value, but we don't have an API to accept int32
and return an int64
value, as in the case of lucas
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @kgryte @Planeshifter
Progresses #649
Description
This pull request:
math/base/special/lucasf
Related Issues
This pull request:
Questions
No.
Other
This branch can further be rebased to include
constants/float32/max-safe-nth-lucas
macro from #3337 instead of using just 34 as it is.Checklist
@stdlib-js/reviewers