Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for blas/base/gdot #4134

Closed
wants to merge 1 commit into from
Closed

feat: add C implementation for blas/base/gdot #4134

wants to merge 1 commit into from

Conversation

gururaj1512
Copy link
Contributor

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for blas/base/gdot

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@gururaj1512
feat: add C implementation for blas/base/gdot
975b91e 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 21, 2024
@kgryte
Copy link
Member

kgryte commented Dec 21, 2024

@gururaj1512 Sorry, we should have coordinated better on this. gdot should not have a C implementation. The only packages which should have C implementations are the explicitly typed packages beginning with d, s, z, or c. The g packages are explicitly intended for any other array which is not covered by those explicit types. E.g., Int32Array or generic JS arrays. There is actually work to be done here, which we can sync on, but the changes in this PR cannot be accepted.

I will close this, and let's sync on Gitter to discuss other steps.

@kgryte kgryte closed this Dec 21, 2024
@kgryte kgryte added Do Not Merge Pull request which should not be merged. and removed Needs Review A pull request which needs code review. labels Dec 21, 2024
@gururaj1512 gururaj1512 deleted the blas-base-gdot branch December 21, 2024 21:09
@gururaj1512
Copy link
Contributor Author

Thank you for the clarification. I understand now that gdot should not have a C implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Do Not Merge Pull request which should not be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gururaj1512 @kgryte @stdlib-bot