Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/dsumpw #4329

Merged
merged 7 commits into from
Jan 8, 2025
Merged

feat: add C ndarray API and refactor blas/ext/base/dsumpw #4329

merged 7 commits into from
Jan 8, 2025

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add C ndarray API and refactor/cleanup blas/ext/base/dsumpw

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode
feat: add C ndarray API and refactor
f323391 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Dec 28, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 28, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsumpw $\color{green}434/434$
$\color{green}+100.00\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}434/434$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Dec 28, 2024
@headlessNode headlessNode marked this pull request as ready for review December 28, 2024 18:40
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 28, 2024
kgryte
kgryte requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a quick look at this PR and it seems that it needs the same small changes as the other similar PRs. Would you mind addressing?

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 2, 2025
@headlessNode
fix: apply review suggestions
0703753 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode
fix: apply review suggestions
6d5439c 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode
fix: apply review suggestions
f1345f4 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode
fix: apply review suggestions
964be66 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode
fix: apply review suggestions
3b2cfef 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode
fix: apply review suggestions
3781cbd 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode
Copy link
Member Author

@kgryte changes addressed.

@headlessNode headlessNode requested review from kgryte January 5, 2025 06:47
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. labels Jan 5, 2025
kgryte
kgryte approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit 074b9a1 into stdlib-js:develop Jan 8, 2025
44 checks passed
@kgryte kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Jan 8, 2025
@headlessNode headlessNode deleted the refactor-dsumpw branch January 8, 2025 09:22
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@headlessNode @0PrashantYadav0
feat: add C ndarray API and refactor blas/ext/base/dsumpw
bbc5552 
PR-URL: stdlib-js#4329
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte Awaiting requested review from kgryte

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @stdlib-bot @kgryte