-
-
Notifications
You must be signed in to change notification settings - Fork 936
fix(array/base/fancy-slice): align test expectations with AccessorArray and typed array return types #8438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Added a self-import to satisfy linting rules. Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Fix echo command in eslint-files target for linting. Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
|
I'm going to close this PR. None of what you describe in the OP is done in this PR. I strongly suggest that before using AI you perform manual contributions. In order to effectively use AI in authoring contributions, you need a deep understanding of the project and its conventions. Otherwise, you're just generating AI slop and decreasing the likelihood that your PRs will be merged. |
Resolves #8294 .
Description
This pull request:
@stdlib/array/base/fancy-slicemodule caused by recent updates introducingAccessorArrayand consistent typed array outputs.Specifically, it:
AccessorArrayandFloat64Arrayoutputs instead of plain JavaScript arrays ([]).Related Issues
This pull request has the following related issues:
Questions
No.
Other
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers