Merge pull request #1181 from stealjs/attr-name

Use attr.name to get an attribute's name
stealjs · Apr 25, 2017 · ba6c847 · ba6c847
2 parents 0988858 + c6233bc
commit ba6c847
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 15 deletions.
diff --git a/main.js b/main.js
@@ -1404,11 +1404,12 @@ addStealExtension(function (loader) {
 		scriptOptions.stealURL = script.src;
 
 		each(script.attributes, function(attr){
+			var nodeName = attr.nodeName || attr.name;
 			// get option, remove "data" and camelize
 			var optionName =
-				camelize( attr.nodeName.indexOf("data-") === 0 ?
-					attr.nodeName.replace("data-","") :
-					attr.nodeName );
+				camelize( nodeName.indexOf("data-") === 0 ?
+					nodeName.replace("data-","") :
+					nodeName );
 			// make options uniform e.g. baseUrl => baseURL
 			optionName = optionName.replace(urlRegEx, "URL")
 			scriptOptions[optionName] = (attr.value === "") ? true : attr.value;

diff --git a/src/startup.js b/src/startup.js
@@ -36,11 +36,12 @@
 		scriptOptions.stealURL = script.src;
 
 		each(script.attributes, function(attr){
+			var nodeName = attr.nodeName || attr.name;
 			// get option, remove "data" and camelize
 			var optionName =
-				camelize( attr.nodeName.indexOf("data-") === 0 ?
-					attr.nodeName.replace("data-","") :
-					attr.nodeName );
+				camelize( nodeName.indexOf("data-") === 0 ?
+					nodeName.replace("data-","") :
+					nodeName );
 			// make options uniform e.g. baseUrl => baseURL
 			optionName = optionName.replace(urlRegEx, "URL")
 			scriptOptions[optionName] = (attr.value === "") ? true : attr.value;

diff --git a/steal-sans-promises.js b/steal-sans-promises.js
@@ -5705,11 +5705,12 @@ addStealExtension(function (loader) {
 		scriptOptions.stealURL = script.src;
 
 		each(script.attributes, function(attr){
+			var nodeName = attr.nodeName || attr.name;
 			// get option, remove "data" and camelize
 			var optionName =
-				camelize( attr.nodeName.indexOf("data-") === 0 ?
-					attr.nodeName.replace("data-","") :
-					attr.nodeName );
+				camelize( nodeName.indexOf("data-") === 0 ?
+					nodeName.replace("data-","") :
+					nodeName );
 			// make options uniform e.g. baseUrl => baseURL
 			optionName = optionName.replace(urlRegEx, "URL")
 			scriptOptions[optionName] = (attr.value === "") ? true : attr.value;

diff --git a/steal-sans-promises.production.js b/steal-sans-promises.production.js
diff --git a/steal.js b/steal.js
@@ -6975,11 +6975,12 @@ addStealExtension(function (loader) {
 		scriptOptions.stealURL = script.src;
 
 		each(script.attributes, function(attr){
+			var nodeName = attr.nodeName || attr.name;
 			// get option, remove "data" and camelize
 			var optionName =
-				camelize( attr.nodeName.indexOf("data-") === 0 ?
-					attr.nodeName.replace("data-","") :
-					attr.nodeName );
+				camelize( nodeName.indexOf("data-") === 0 ?
+					nodeName.replace("data-","") :
+					nodeName );
 			// make options uniform e.g. baseUrl => baseURL
 			optionName = optionName.replace(urlRegEx, "URL")
 			scriptOptions[optionName] = (attr.value === "") ? true : attr.value;

diff --git a/steal.production.js b/steal.production.js
diff --git a/test/npm/bower/node_modules/steal/steal.production.js b/test/npm/bower/node_modules/steal/steal.production.js